Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: media/blink/webmediaplayer_impl_unittest.cc

Issue 2711153006: Add RendererFactorySelector (Closed)
Patch Set: Removed flat_map. Temp fix of -Wsometimes-initialized Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl_unittest.cc
diff --git a/media/blink/webmediaplayer_impl_unittest.cc b/media/blink/webmediaplayer_impl_unittest.cc
index f607b65c5c85919a5709700a14dae45cd0c7501c..65fe1976f25c23a32527cfb151750ff508724d89 100644
--- a/media/blink/webmediaplayer_impl_unittest.cc
+++ b/media/blink/webmediaplayer_impl_unittest.cc
@@ -211,14 +211,19 @@ class WebMediaPlayerImplTest : public testing::Test {
void InitializeWebMediaPlayerImpl(bool allow_suspend) {
std::unique_ptr<MediaLog> media_log(new MediaLog());
- std::unique_ptr<RendererFactory> renderer_factory(
- new DefaultRendererFactory(
+
+ auto factory_selector = base::MakeUnique<RendererFactorySelector>();
+ factory_selector->AddFactory(
+ RendererFactorySelector::FactoryType::DEFAULT,
+ base::MakeUnique<DefaultRendererFactory>(
media_log.get(), nullptr,
DefaultRendererFactory::GetGpuFactoriesCB()));
+ factory_selector->SetBaseFactoryType(
+ RendererFactorySelector::FactoryType::DEFAULT);
wmpi_ = base::MakeUnique<WebMediaPlayerImpl>(
web_local_frame_, &client_, nullptr, &delegate_,
- std::move(renderer_factory), url_index_,
+ std::move(factory_selector), url_index_,
base::MakeUnique<WebMediaPlayerParams>(
std::move(media_log), WebMediaPlayerParams::DeferLoadCB(),
scoped_refptr<SwitchableAudioRendererSink>(),
« no previous file with comments | « media/blink/webmediaplayer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698