Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: runtime/vm/BUILD.gn

Issue 2710943006: Make patch_sdk step invoke fasta's compile_platform to generate patched_sdk/platform.dill. (Closed)
Patch Set: Add kernel and front_end to dependencies Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/BUILD.gn
diff --git a/runtime/vm/BUILD.gn b/runtime/vm/BUILD.gn
index cada1133bab6c393f9c40b1002a1134355601b92..19ba41f08a7ca1b9645057e9024f90730026ca06 100644
--- a/runtime/vm/BUILD.gn
+++ b/runtime/vm/BUILD.gn
@@ -406,6 +406,20 @@ template("generate_patched_sdk") {
],
"list lines")
+ front_end_sources = exec_script("../../tools/list_dart_files.py",
+ [
+ "absolute",
+ rebase_path("../../pkg/front_end"),
+ ],
+ "list lines")
+
+ kernel_sources = exec_script("../../tools/list_dart_files.py",
kustermann 2017/03/02 12:14:14 These exec_script things have just broken the buil
+ [
+ "absolute",
+ rebase_path("../../pkg/kernel"),
+ ],
+ "list lines")
+
# We list the `patch_sdk.dart` tool here because the [script] (which is
# implicitly an input) will call it.
inputs = [
@@ -427,6 +441,10 @@ template("generate_patched_sdk") {
# Add all the concatenated patch files.
inputs += concatenation_files
+ # Add some front-end dependencies
+ inputs += front_end_sources
+ inputs += kernel_sources
+
outputs = [
# Instead of listing all outputs we list a single well-known one.
"${patched_sdk_dir}/lib/core/core.dart",
@@ -448,6 +466,7 @@ template("generate_patched_sdk") {
rebase_path("../../sdk"),
rebase_path(patches_dir, root_build_dir),
rebase_path(patched_sdk_dir, root_build_dir),
+ rebase_path("../../.packages"),
]
}
}

Powered by Google App Engine
This is Rietveld 408576698