[InputEvent] Change |InputEventInit::sequence<Range> ranges| to |sequence<StaticRange> targetRanges|

[InputEvent] Change |InputEventInit::sequence<Range> ranges| to |sequence<StaticRange> targetRanges|

See spec https://w3c.github.io/input-events/#h-interface-inputevent

BUG=692700
Review-Url: https://codereview.chromium.org/2709883004
Cr-Commit-Position: refs/heads/master@{#453306}
Committed: https://chromium.googlesource.com/chromium/src/+/73324e59ad313ca374603b571167e688ca505080

[chongz, 2017-02-21 22:45:06]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[chongz, 2017-02-21 22:45:47]

Description was changed from

==========
Rename InputEventInit::ranges to targetRanges

BUG=692700
==========

to

==========
[InputEvent] Rename InputEventInit::ranges to targetRanges

See spec https://w3c.github.io/input-events/#h-interface-inputevent

BUG=692700
==========

[commit-bot: I haz the power, 2017-02-21 22:46:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2017-02-22 00:12:58]

chongz@chromium.org changed reviewers:
+ yosin@chromium.org

[chongz, 2017-02-22 00:12:59]

yosin@ PTAL, thanks!

[commit-bot: I haz the power, 2017-02-22 00:50:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:50:12]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[yosin_UTC9, 2017-02-22 06:46:44]

lgtm

Do we have WPT tests for InputEvent?
If not, it seems not since this patch doesn't change, we should have them.

[chongz, 2017-02-23 16:35:52]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 16:36:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chongz, 2017-02-23 18:03:06]

Description was changed from

==========
[InputEvent] Rename InputEventInit::ranges to targetRanges

See spec https://w3c.github.io/input-events/#h-interface-inputevent

BUG=692700
==========

to

==========
[InputEvent] Change |InputEventInit::sequence<Range> ranges| to
|sequence<StaticRange> targetRanges|

See spec https://w3c.github.io/input-events/#h-interface-inputevent

BUG=692700
==========

[commit-bot: I haz the power, 2017-02-23 18:04:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 18:04:21]

Dry run: This issue passed the CQ dry run.

[chongz, 2017-02-24 03:33:45]

yosin@ I've also changed |targetRanges| to use |StaticRange| to avoid writing
twice. PTAL again, thanks!

[yosin_UTC9, 2017-02-24 06:37:14]

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:208:
ranges->push_back(
nit: s/push_back/emplace_back/
It seems WTF::Vector supports C++11 way. (^_^)

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/InputEvent.cpp (right):

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:96: if
(initializer.hasTargetRanges()) {
Prefer early return style.

if (!initializer.hasTargetRanges())
  return;

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:97: m_ranges.clear();
It seems noboday add elements to |m_ranges| since this function is constructor.

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:98: for (const auto& range
: initializer.targetRanges())
Can we do |m_ranges = initializer.targetRanges()|?

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:99:
m_ranges.push_back(range->toRange());
nit: s/push_back/emplace_back/

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:172:
staticRanges.push_back(StaticRange::create(range));
nit: s/push_back/emplace_back/

[chongz, 2017-02-24 15:55:22]

The CQ bit was checked by chongz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 15:55:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 17:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 17:19:27]

Dry run: This issue passed the CQ dry run.

[chongz, 2017-02-24 21:19:16]

yosin@ PTAL again, thanks!

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:208:
ranges->push_back(
On 2017/02/24 06:37:14, yosin_UTC9 wrote:
> nit: s/push_back/emplace_back/
> It seems WTF::Vector supports C++11 way. (^_^)

It seems that I cannot use |emplace_back()| as there is only one argument, see:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/wtf/Vector.h?s...

The |static_assert()| is suggesting |append()|, but I don't feel it's better
than |push_back()|...

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/InputEvent.cpp (right):

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:96: if
(initializer.hasTargetRanges()) {
On 2017/02/24 06:37:14, yosin_UTC9 wrote:
> Prefer early return style.
> 
> if (!initializer.hasTargetRanges())
>   return;

Done.

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:97: m_ranges.clear();
On 2017/02/24 06:37:14, yosin_UTC9 wrote:
> It seems noboday add elements to |m_ranges| since this function is
constructor.

Removed.

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:98: for (const auto& range
: initializer.targetRanges())
On 2017/02/24 06:37:14, yosin_UTC9 wrote:
> Can we do |m_ranges = initializer.targetRanges()|?

|initializer.targetRanges()| is of type |HeapVector<Member<StaticRange>>|, and
|m_ranges| is of type |HeapVector<Member<Range>>|.

I'm not sure but do we have some magic conversion utilities for vectors?

[yosin_UTC9, 2017-02-27 10:31:46]

lgtm

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right):

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:208:
ranges->push_back(
On 2017/02/24 at 21:19:15, chongz wrote:
> On 2017/02/24 06:37:14, yosin_UTC9 wrote:
> > nit: s/push_back/emplace_back/
> > It seems WTF::Vector supports C++11 way. (^_^)
> 
> It seems that I cannot use |emplace_back()| as there is only one argument,
see:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/wtf/Vector.h?s...
> 
> The |static_assert()| is suggesting |append()|, but I don't feel it's better
than |push_back()|...

I see. Thanks for notice.

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/InputEvent.cpp (right):

https://codereview.chromium.org/2709883004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/InputEvent.cpp:98: for (const auto& range
: initializer.targetRanges())
On 2017/02/24 at 21:19:15, chongz wrote:
> On 2017/02/24 06:37:14, yosin_UTC9 wrote:
> > Can we do |m_ranges = initializer.targetRanges()|?
> 
> |initializer.targetRanges()| is of type |HeapVector<Member<StaticRange>>|, and
|m_ranges| is of type |HeapVector<Member<Range>>|.
> 
> I'm not sure but do we have some magic conversion utilities for vectors?

No.

[chongz, 2017-02-27 15:38:32]

chongz@chromium.org changed reviewers:
+ ojan@chromium.org

[chongz, 2017-02-27 15:38:32]

ojan@ PTAL, thanks!

[ojan, 2017-02-27 18:01:55]

The CQ bit was checked by ojan@chromium.org

[ojan, 2017-02-27 18:01:56]

lgtm

[commit-bot: I haz the power, 2017-02-27 18:03:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:55:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488218515936060,
"parent_rev": "0f907f2463c4ba3b314f0142e0d1a171bf5f2598", "commit_rev":
"73324e59ad313ca374603b571167e688ca505080"}

[commit-bot: I haz the power, 2017-02-27 19:56:54]

Description was changed from

==========
[InputEvent] Change |InputEventInit::sequence<Range> ranges| to
|sequence<StaticRange> targetRanges|

See spec https://w3c.github.io/input-events/#h-interface-inputevent

BUG=692700
==========

to

==========
[InputEvent] Change |InputEventInit::sequence<Range> ranges| to
|sequence<StaticRange> targetRanges|

See spec https://w3c.github.io/input-events/#h-interface-inputevent

BUG=692700

Review-Url: https://codereview.chromium.org/2709883004
Cr-Commit-Position: refs/heads/master@{#453306}
Committed:
https://chromium.googlesource.com/chromium/src/+/73324e59ad313ca374603b571167...
==========

[commit-bot: I haz the power, 2017-02-27 19:56:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/73324e59ad313ca374603b571167...