Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2709163008: [Android Crash Reporting] Componentize MinidumpUploadImpl.java (Closed)

Created:
3 years, 10 months ago by Ilya Sherman
Modified:
3 years, 9 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android Crash Reporting] Componentize MinidumpUploadImpl.java BUG=694884 TEST=compile, android_webview_test_apk R=gsennton@chromium.org Review-Url: https://codereview.chromium.org/2709163008 Cr-Commit-Position: refs/heads/master@{#454390} Committed: https://chromium.googlesource.com/chromium/src/+/375b5de438487e3fe5b52014a5962822b59f0d19

Patch Set 1 #

Total comments: 16

Patch Set 2 : Finish the componentization #

Total comments: 6

Patch Set 3 : Update comments #

Patch Set 4 : Partial rebase #

Patch Set 5 : Finished rebase #

Messages

Total messages: 28 (15 generated)
Ilya Sherman
Hi Gustav, I'm still working on this CL, and it's not quite ready for review. ...
3 years, 10 months ago (2017-02-24 02:25:41 UTC) #5
gsennton
Thanks for going through this Ilya! I know you have to go through this for ...
3 years, 10 months ago (2017-02-24 15:48:19 UTC) #6
Ilya Sherman
Hokay, ready for a full review. Thanks for the comments on the intermediate patch set! ...
3 years, 10 months ago (2017-02-25 01:04:39 UTC) #8
gsennton
https://codereview.chromium.org/2709163008/diff/1/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java File components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java (right): https://codereview.chromium.org/2709163008/diff/1/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java#newcode41 components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java:41: // synchronization for it, e.g. should this be an ...
3 years, 9 months ago (2017-02-27 18:54:56 UTC) #9
Ilya Sherman
https://codereview.chromium.org/2709163008/diff/100001/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java File android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java (right): https://codereview.chromium.org/2709163008/diff/100001/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java#newcode59 android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java:59: // TODO(isherman): This code should really be shared with ...
3 years, 9 months ago (2017-02-28 03:54:13 UTC) #10
gsennton
lgtm
3 years, 9 months ago (2017-02-28 16:35:30 UTC) #15
Ilya Sherman
Toby, I realize that this CL mixes a few different changes together, so I split ...
3 years, 9 months ago (2017-03-01 00:52:26 UTC) #16
Ilya Sherman
On 2017/03/01 00:52:26, Ilya Sherman wrote: > Toby, I realize that this CL mixes a ...
3 years, 9 months ago (2017-03-01 18:19:09 UTC) #17
Tobias Sargeant
On 2017/03/01 18:19:09, Ilya Sherman wrote: > On 2017/03/01 00:52:26, Ilya Sherman wrote: > > ...
3 years, 9 months ago (2017-03-02 12:22:04 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709163008/160001
3 years, 9 months ago (2017-03-02 17:30:49 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/129883)
3 years, 9 months ago (2017-03-02 19:09:00 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709163008/160001
3 years, 9 months ago (2017-03-02 21:15:44 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 21:58:04 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/375b5de438487e3fe5b52014a596...

Powered by Google App Engine
This is Rietveld 408576698