Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3631)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java

Issue 2707993003: [Android]: Hide add-to-homescreen app menu item when WebAPK is installed (Closed)
Patch Set: Add new state for 'Add to Homescreen' Menu item Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
index d4c720db772886bae5d7b6c806d2b319259bda53..330b1c1d9311dc56c1d365f3793d5a9e124366a6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java
@@ -13,7 +13,6 @@ import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.DefaultBrowserInfo;
import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.appmenu.AppMenuPropertiesDelegate;
-import org.chromium.chrome.browser.banners.AppBannerManager;
import org.chromium.chrome.browser.download.DownloadUtils;
import org.chromium.chrome.browser.firstrun.FirstRunStatus;
import org.chromium.chrome.browser.share.ShareHelper;
@@ -78,8 +77,8 @@ public class CustomTabAppMenuPropertiesDelegate extends AppMenuPropertiesDelegat
MenuItem openInChromeItem = menu.findItem(R.id.open_in_browser_id);
MenuItem bookmarkItem = menu.findItem(R.id.bookmark_this_page_id);
MenuItem downloadItem = menu.findItem(R.id.offline_page_id);
- MenuItem addToHomeScreenItem = menu.findItem(R.id.add_to_homescreen_id);
- addToHomeScreenItem.setTitle(AppBannerManager.getHomescreenLanguageOption());
+
+ boolean addToHomeScreenVisible = true;
// Hide request desktop site on all chrome:// pages except for the NTP. Check request
// desktop site if it's activated on this page.
@@ -92,7 +91,7 @@ public class CustomTabAppMenuPropertiesDelegate extends AppMenuPropertiesDelegat
openInChromeItem.setVisible(false);
menu.findItem(R.id.find_in_page_id).setVisible(false);
menu.findItem(R.id.request_desktop_site_id).setVisible(false);
- addToHomeScreenItem.setVisible(false);
+ addToHomeScreenVisible = false;
} else {
openInChromeItem.setTitle(
DefaultBrowserInfo.getTitleOpenInDefaultBrowser(mIsOpenedByChrome));
@@ -103,7 +102,7 @@ public class CustomTabAppMenuPropertiesDelegate extends AppMenuPropertiesDelegat
openInChromeItem.setVisible(false);
bookmarkItem.setVisible(false);
downloadItem.setVisible(false);
- addToHomeScreenItem.setVisible(false);
+ addToHomeScreenVisible = false;
}
downloadItem.setEnabled(DownloadUtils.isAllowedToDownloadPage(currentTab));
@@ -112,7 +111,7 @@ public class CustomTabAppMenuPropertiesDelegate extends AppMenuPropertiesDelegat
boolean isChromeScheme = url.startsWith(UrlConstants.CHROME_URL_PREFIX)
|| url.startsWith(UrlConstants.CHROME_NATIVE_URL_PREFIX);
if (isChromeScheme) {
- addToHomeScreenItem.setVisible(false);
+ addToHomeScreenVisible = false;
}
// Add custom menu items. Make sure they are only added once.
@@ -123,6 +122,8 @@ public class CustomTabAppMenuPropertiesDelegate extends AppMenuPropertiesDelegat
mItemToIndexMap.put(item, i);
}
}
+
+ prepareAddToHomescreenMenuItem(menu, currentTab.getUrl(), addToHomeScreenVisible);
}
}

Powered by Google App Engine
This is Rietveld 408576698