Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2707243004: Enable NTPPreferAmpUrls in testing config. (Closed)

Created:
3 years, 10 months ago by Michael van Ouwerkerk
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable NTPPreferAmpUrls in testing config. BUG=668095 Review-Url: https://codereview.chromium.org/2707243004 Cr-Commit-Position: refs/heads/master@{#452789} Committed: https://chromium.googlesource.com/chromium/src/+/9886ea7758ec1eba22f6787b21159c531e0808a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config.json View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Michael van Ouwerkerk
Marc, could you take a look please?
3 years, 10 months ago (2017-02-23 15:33:14 UTC) #3
Marc Treib
Wait, it looks like this has always been enabled by default anyway. In that case, ...
3 years, 10 months ago (2017-02-23 15:38:14 UTC) #5
Michael van Ouwerkerk
Alexei, could you take a look as owner please?
3 years, 10 months ago (2017-02-23 15:38:31 UTC) #7
Michael van Ouwerkerk
On 2017/02/23 15:38:14, Marc Treib wrote: > Wait, it looks like this has always been ...
3 years, 10 months ago (2017-02-23 15:39:11 UTC) #8
Alexei Svitkine (slow)
lgtm
3 years, 10 months ago (2017-02-23 18:55:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2707243004/1
3 years, 10 months ago (2017-02-24 10:27:30 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 10:32:39 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9886ea7758ec1eba22f6787b2115...

Powered by Google App Engine
This is Rietveld 408576698