Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 27069006: [Autofill] Add support for three pairs of new server field types. (Closed)

Created:
7 years, 2 months ago by Ilya Sherman
Modified:
7 years, 2 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

[Autofill] Add support for three pairs of new server field types. The field types included are "home" and "billing" variants of street address, sorting code, and dependent locality. Support for these has already been added to the server. BUG=299154, 280499 TEST=unit_tests R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229340

Patch Set 1 #

Total comments: 8

Patch Set 2 : Rebase #

Patch Set 3 : Fix typos in comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -37 lines) Patch
M components/autofill/core/browser/address.cc View 6 chunks +53 lines, -13 lines 0 comments Download
M components/autofill/core/browser/address_unittest.cc View 1 chunk +71 lines, -16 lines 0 comments Download
M components/autofill/core/browser/autofill_type.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_type.cc View 6 chunks +38 lines, -1 line 0 comments Download
M components/autofill/core/browser/field_types.h View 1 2 2 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ilya Sherman
7 years, 2 months ago (2013-10-12 01:08:49 UTC) #1
Evan Stade
https://codereview.chromium.org/27069006/diff/1/components/autofill/core/browser/address.cc File components/autofill/core/browser/address.cc (right): https://codereview.chromium.org/27069006/diff/1/components/autofill/core/browser/address.cc#newcode179 components/autofill/core/browser/address.cc:179: value.find(char16('\n')) == base::string16::npos) { is it possible to put ...
7 years, 2 months ago (2013-10-16 23:18:32 UTC) #2
Ilya Sherman
https://codereview.chromium.org/27069006/diff/1/components/autofill/core/browser/address.cc File components/autofill/core/browser/address.cc (right): https://codereview.chromium.org/27069006/diff/1/components/autofill/core/browser/address.cc#newcode179 components/autofill/core/browser/address.cc:179: value.find(char16('\n')) == base::string16::npos) { On 2013/10/16 23:18:33, Evan Stade ...
7 years, 2 months ago (2013-10-17 01:12:35 UTC) #3
Evan Stade
https://codereview.chromium.org/27069006/diff/1/components/autofill/core/browser/address.cc File components/autofill/core/browser/address.cc (right): https://codereview.chromium.org/27069006/diff/1/components/autofill/core/browser/address.cc#newcode179 components/autofill/core/browser/address.cc:179: value.find(char16('\n')) == base::string16::npos) { On 2013/10/17 01:12:35, Ilya Sherman ...
7 years, 2 months ago (2013-10-17 02:27:30 UTC) #4
Ilya Sherman
https://codereview.chromium.org/27069006/diff/1/components/autofill/core/browser/address.cc File components/autofill/core/browser/address.cc (right): https://codereview.chromium.org/27069006/diff/1/components/autofill/core/browser/address.cc#newcode179 components/autofill/core/browser/address.cc:179: value.find(char16('\n')) == base::string16::npos) { On 2013/10/17 02:27:30, Evan Stade ...
7 years, 2 months ago (2013-10-17 02:53:25 UTC) #5
Evan Stade
lgtm
7 years, 2 months ago (2013-10-17 14:57:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/27069006/8001
7 years, 2 months ago (2013-10-17 21:02:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/27069006/8001
7 years, 2 months ago (2013-10-18 01:33:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/27069006/8001
7 years, 2 months ago (2013-10-18 02:15:51 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-18 09:52:33 UTC) #10
Message was sent while issue was closed.
Change committed as 229340

Powered by Google App Engine
This is Rietveld 408576698