Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2706253002: Change creation order of TabModel observers. (Closed)

Created:
3 years, 10 months ago by sdefresne
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change creation order of TabModel observers. In preparation of future refactoring, create the TabModel observers after setting the other ivar and creating the other internal objects (in particular the TabUsageRecorder). BUG=687207 Review-Url: https://codereview.chromium.org/2706253002 Cr-Commit-Position: refs/heads/master@{#452533} Committed: https://chromium.googlesource.com/chromium/src/+/419718939c4af924bcc43dea66656ec03419cb7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M ios/chrome/browser/tabs/tab_model.mm View 1 chunk +16 lines, -14 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
sdefresne
To whoever will be fastest.
3 years, 10 months ago (2017-02-21 16:32:58 UTC) #2
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-21 16:37:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2706253002/1
3 years, 10 months ago (2017-02-23 16:37:24 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 17:24:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/419718939c4af924bcc43dea6665...

Powered by Google App Engine
This is Rietveld 408576698