Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3634)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java

Issue 2703463002: [List UI Unification] Basic list unification for phones (Closed)
Patch Set: [List UI Unification] Basic list unification for phones Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java b/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
index 0343eb4599e29a4669d5a9611922c64896791f59..0b3120192a4fc8769c7c226c34cbaec5dcb6c38b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java
@@ -23,6 +23,7 @@ import org.chromium.chrome.browser.widget.RoundedIconGenerator;
import org.chromium.chrome.browser.widget.TintedImageButton;
import org.chromium.chrome.browser.widget.displaystyle.MarginResizer;
import org.chromium.chrome.browser.widget.selection.SelectableItemView;
+import org.chromium.chrome.browser.widget.selection.SelectableListLayout;
/**
* The SelectableItemView for items displayed in the browsing history UI.
@@ -127,7 +128,7 @@ public class HistoryItemView extends SelectableItemView<HistoryItem> implements
MarginResizer.createWithViewAdapter(this,
mHistoryManager.getSelectableListLayout().getUiConfig(),
- mHistoryManager.getDefaultLateralListItemMarginPx(), 0);
+ SelectableListLayout.getDefaultListItemLateralMarginPx(getResources()), 0);
}
/**
@@ -203,20 +204,7 @@ public class HistoryItemView extends SelectableItemView<HistoryItem> implements
* Sets the background resource for this view using the item's positioning in its group.
*/
public void setBackgroundResourceForGroupPosition() {
- int backgroundResource;
-
- boolean isLastInGroup = getItem().isLastInGroup();
- boolean isFirstInGroup = getItem().isFirstInGroup();
- if (!isLastInGroup && !isFirstInGroup) {
- backgroundResource = R.drawable.list_item_middle;
- } else if (!isLastInGroup) {
- backgroundResource = R.drawable.list_item_top;
- } else if (!isFirstInGroup) {
- backgroundResource = R.drawable.list_item_bottom;
- } else {
- backgroundResource = R.drawable.list_item_single;
- }
-
- setBackgroundResource(backgroundResource);
+ setBackgroundResourceForGroupPosition(
+ getItem().isFirstInGroup(), getItem().isLastInGroup());
}
}

Powered by Google App Engine
This is Rietveld 408576698