Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 27034005: Add rule for generating lexer and implement lexer shell. (Closed)

Created:
7 years, 2 months ago by ulan
Modified:
7 years, 2 months ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

Add rule for generating lexer and implement lexer shell. R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17188

Patch Set 1 : #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -36 lines) Patch
M Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + src/lexer/lexer.gyp View 1 chunk +38 lines, -36 lines 0 comments Download
A src/lexer/lexer-shell.cc View 1 1 chunk +135 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marja
lgtm
7 years, 2 months ago (2013-10-14 11:31:46 UTC) #1
ulan
7 years, 2 months ago (2013-10-14 11:35:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r17188 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698