Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.h

Issue 2703333006: Move the notion of current Tab from TabModel to WebStateList. (Closed)
Patch Set: Rebase. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.h
diff --git a/ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.h b/ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.h
index 7c18934820c01deec3a0ea43e3c595c8a97ef5dc..4e2308559feb87abcb4d3200997a6528c33f68d4 100644
--- a/ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.h
+++ b/ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.h
@@ -13,6 +13,9 @@ class WebStateListMetricsObserver : public WebStateListObserver {
WebStateListMetricsObserver();
~WebStateListMetricsObserver() override;
+ void ResetSessionMetrics();
+ void RecordSessionMetrics();
+
// WebStateListObserver implementation.
void WebStateInsertedAt(WebStateList* web_state_list,
web::WebState* web_state,
@@ -24,8 +27,18 @@ class WebStateListMetricsObserver : public WebStateListObserver {
void WebStateDetachedAt(WebStateList* web_state_list,
web::WebState* web_state,
int index) override;
+ void WebStateActivatedAt(WebStateList* web_state_list,
+ web::WebState* old_web_state,
+ web::WebState* new_web_state,
+ int active_index,
+ bool user_action) override;
private:
+ // Counters for metrics.
+ int inserted_web_state_counter_;
+ int detached_web_state_counter_;
+ int activated_web_state_counter_;
+
DISALLOW_COPY_AND_ASSIGN(WebStateListMetricsObserver);
};
« no previous file with comments | « ios/shared/chrome/browser/tabs/web_state_list.mm ('k') | ios/shared/chrome/browser/tabs/web_state_list_metrics_observer.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698