Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2701843002: Remove ImageDataFetcher from iOS. (Closed)

Created:
3 years, 10 months ago by gambard
Modified:
3 years, 10 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ImageDataFetcher from iOS. This class has been replaced by IOSImageDataFetcherWrapper. BUG=683918 Review-Url: https://codereview.chromium.org/2701843002 Cr-Commit-Position: refs/heads/master@{#451316} Committed: https://chromium.googlesource.com/chromium/src/+/0a8d5c8ec4460a99cb0aaa3b17fae5eb52ca5288

Patch Set 1 #

Patch Set 2 : Remove mock #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -546 lines) Patch
M ios/web/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/public/image_fetcher/BUILD.gn View 2 chunks +0 lines, -6 lines 0 comments Download
D ios/web/public/image_fetcher/image_data_fetcher.h View 1 chunk +0 lines, -96 lines 0 comments Download
D ios/web/public/image_fetcher/image_data_fetcher.mm View 1 chunk +0 lines, -179 lines 0 comments Download
D ios/web/public/image_fetcher/image_data_fetcher_unittest.mm View 1 chunk +0 lines, -212 lines 0 comments Download
D ios/web/public/test/mock_image_data_fetcher.h View 1 1 chunk +0 lines, -36 lines 0 comments Download
D ios/web/public/test/mock_image_data_fetcher.mm View 1 1 chunk +0 lines, -15 lines 0 comments Download

Dependent Patchsets:

Issue 2699633006 Patch 20001
Issue 2699633006 Patch 30001

Messages

Total messages: 22 (11 generated)
gambard
PTAL.
3 years, 10 months ago (2017-02-17 08:39:28 UTC) #2
sdefresne
lgtm
3 years, 10 months ago (2017-02-17 10:23:59 UTC) #3
sdefresne
lgtm lgtm
3 years, 10 months ago (2017-02-17 10:24:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701843002/1
3 years, 10 months ago (2017-02-17 10:46:41 UTC) #6
gambard
Removing mock for the ImageFetcher
3 years, 10 months ago (2017-02-17 10:53:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701843002/20001
3 years, 10 months ago (2017-02-17 10:54:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/121461)
3 years, 10 months ago (2017-02-17 12:42:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701843002/20001
3 years, 10 months ago (2017-02-17 12:44:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/121498)
3 years, 10 months ago (2017-02-17 14:54:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701843002/20001
3 years, 10 months ago (2017-02-17 15:31:08 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 16:15:07 UTC) #22
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a8d5c8ec4460a99cb0aaa3b17fa...

Powered by Google App Engine
This is Rietveld 408576698