Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 2701703003: DevTools: Add user metric for CPU throttling enable. (Closed)

Created:
3 years, 10 months ago by alph
Modified:
3 years, 10 months ago
Reviewers:
jwd, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Add user metric for CPU throttling enable. Review-Url: https://codereview.chromium.org/2701703003 Cr-Commit-Position: refs/heads/master@{#451474} Committed: https://chromium.googlesource.com/chromium/src/+/7107711700a771193381657fd0be463350395f2f

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/inspector/user-metrics-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/CPUThrottlingManager.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/UserMetrics.js View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
alph
3 years, 10 months ago (2017-02-17 02:02:55 UTC) #2
alph
ptal
3 years, 10 months ago (2017-02-17 02:07:09 UTC) #4
pfeldman
lgtm if it isn't used, we'll have to remove it now.
3 years, 10 months ago (2017-02-17 19:05:45 UTC) #5
jwd
lgtm
3 years, 10 months ago (2017-02-17 22:36:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701703003/1
3 years, 10 months ago (2017-02-17 23:10:24 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-18 01:15:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701703003/20001
3 years, 10 months ago (2017-02-18 16:10:19 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 17:41:57 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7107711700a771193381657fd0be...

Powered by Google App Engine
This is Rietveld 408576698