Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4818)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2699933003: Generalize abort tracking to page end state tracking (Closed)
Patch Set: fix comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
index cb3c0ca4e6fe30db2919d057ef541165548ec2a4..ce4a75cef8b14c85e838fc8ef6244496fc83ee03 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
@@ -14,9 +14,9 @@ PageLoadExtraInfo::PageLoadExtraInfo(
const GURL& url,
const GURL& start_url,
bool did_commit,
- UserAbortType abort_type,
- UserInitiatedInfo abort_user_initiated_info,
- const base::Optional<base::TimeDelta>& time_to_abort,
+ PageEndReason page_end_reason,
+ UserInitiatedInfo page_end_user_initiated_info,
+ const base::Optional<base::TimeDelta>& page_end_time,
const PageLoadMetadata& metadata)
: first_background_time(first_background_time),
first_foreground_time(first_foreground_time),
@@ -25,9 +25,9 @@ PageLoadExtraInfo::PageLoadExtraInfo(
url(url),
start_url(start_url),
did_commit(did_commit),
- abort_type(abort_type),
- abort_user_initiated_info(abort_user_initiated_info),
- time_to_abort(time_to_abort),
+ page_end_reason(page_end_reason),
+ page_end_user_initiated_info(page_end_user_initiated_info),
+ page_end_time(page_end_time),
metadata(metadata) {}
PageLoadExtraInfo::PageLoadExtraInfo(const PageLoadExtraInfo& other) = default;

Powered by Google App Engine
This is Rietveld 408576698