Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4996)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2699933003: Generalize abort tracking to page end state tracking (Closed)
Patch Set: fix comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index a9c4f95aaefd8c1a784d23fd795b897011129fcb..14b2c694246d2c939169a7a454251f2fe1a65e44 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -87,6 +87,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, NewPage) {
histogram_tester_.ExpectTotalCount(
internal::kHistogramParseBlockedOnScriptExecution, 1);
histogram_tester_.ExpectTotalCount(internal::kHistogramTotalBytes, 1);
+ histogram_tester_.ExpectTotalCount(internal::kHistogramPageTimingPageEnd, 1);
// Verify that NoPageLoadMetricsRecorded returns false when PageLoad metrics
// have been recorded.
@@ -439,7 +440,8 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortMultiple) {
internal::kHistogramAbortNewNavigationBeforeCommit, 2);
}
-IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortClientRedirect) {
+IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
+ NoAbortMetricsOnClientRedirect) {
ASSERT_TRUE(embedded_test_server()->Start());
GURL first_url(embedded_test_server()->GetURL("/title1.html"));
@@ -463,8 +465,9 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, AbortClientRedirect) {
manager.WaitForNavigationFinished();
- histogram_tester_.ExpectTotalCount(
- internal::kHistogramAbortClientRedirectBeforeCommit, 1);
+ EXPECT_TRUE(histogram_tester_
+ .GetTotalCountsForPrefix("PageLoad.Experimental.AbortTiming.")
+ .empty());
}
IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,

Powered by Google App Engine
This is Rietveld 408576698