Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4187)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2699933003: Generalize abort tracking to page end state tracking (Closed)
Patch Set: fix comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index e8a7178e666a0408dfdd35a1dd02dec5c0cf924f..721217283885b8fe84e878faa4155183b413a83f 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -104,6 +104,10 @@ TEST_F(CorePageLoadMetricsObserverTest, SingleMetricAfterCommit) {
internal::kHistogramParseBlockedOnScriptExecution,
parse_script_exec_duration.InMilliseconds(), 1);
histogram_tester().ExpectTotalCount(internal::kHistogramFirstTextPaint, 0);
+
+ histogram_tester().ExpectTotalCount(internal::kHistogramPageTimingPageEnd, 1);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramPageTimingFirstBackground, 0);
}
TEST_F(CorePageLoadMetricsObserverTest, MultipleMetricsAfterCommits) {
@@ -260,6 +264,10 @@ TEST_F(CorePageLoadMetricsObserverTest, OnlyBackgroundLaterEvents) {
histogram_tester().ExpectTotalCount(internal::kHistogramLoad, 0);
histogram_tester().ExpectTotalCount(internal::kHistogramFirstTextPaint, 0);
+
+ histogram_tester().ExpectTotalCount(internal::kHistogramPageTimingPageEnd, 0);
+ histogram_tester().ExpectTotalCount(
+ internal::kHistogramPageTimingFirstBackground, 1);
}
TEST_F(CorePageLoadMetricsObserverTest, DontBackgroundQuickerLoad) {

Powered by Google App Engine
This is Rietveld 408576698