Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2545)

Unified Diff: extensions/browser/updater/extension_downloader.cc

Issue 2699663003: Convert utility process extension ParseUpdate IPC to mojo (Closed)
Patch Set: Extensions review comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/extensions/extensions_handler.cc ('k') | extensions/browser/updater/safe_manifest_parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/updater/extension_downloader.cc
diff --git a/extensions/browser/updater/extension_downloader.cc b/extensions/browser/updater/extension_downloader.cc
index b2de04204df9eacb6b93097708432066f9c43703..6babc92187a014feb8de3dd0b550de0d2742f402 100644
--- a/extensions/browser/updater/extension_downloader.cc
+++ b/extensions/browser/updater/extension_downloader.cc
@@ -510,13 +510,11 @@ void ExtensionDownloader::OnManifestFetchComplete(
manifests_queue_.active_request_failure_count(),
url);
VLOG(2) << "beginning manifest parse for " << url;
- scoped_refptr<SafeManifestParser> safe_parser(new SafeManifestParser(
- data,
- base::Bind(
- &ExtensionDownloader::HandleManifestResults,
- weak_ptr_factory_.GetWeakPtr(),
- base::Owned(manifests_queue_.reset_active_request().release()))));
- safe_parser->Start();
+ auto callback = base::Bind(
+ &ExtensionDownloader::HandleManifestResults,
+ weak_ptr_factory_.GetWeakPtr(),
+ base::Owned(manifests_queue_.reset_active_request().release()));
+ ParseUpdateManifest(data, callback);
} else {
VLOG(1) << "Failed to fetch manifest '" << url.possibly_invalid_spec()
<< "' response code:" << response_code;
« no previous file with comments | « chrome/utility/extensions/extensions_handler.cc ('k') | extensions/browser/updater/safe_manifest_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698