MD Settings: fix page to work with vulcanize (when it lands and sticks)

MD Settings: fix page to work with vulcanize (when it lands and sticks)

R=dpapad@chromium.org
BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[Dan Beam, 2017-02-17 19:06:26]

Description was changed from

==========
MD Settings: fix page to work with vulcanize (when it lands and sticks)

R=dpapad@chromium.org
BUG=673825
==========

to

==========
MD Settings: fix page to work with vulcanize (when it lands and sticks)

R=dpapad@chromium.org
BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-17 19:09:14]

LGTM

https://codereview.chromium.org/2699063003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_resources.grd (right):

https://codereview.chromium.org/2699063003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_resources.grd:964: preprocess="true"
It does not hurt to move this change in this CL, but it is a bit odd, since the
other CL is the one adding the first (and only) <if expr> in that file.

[Dan Beam, 2017-02-17 19:19:34]

https://codereview.chromium.org/2699063003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_resources.grd (right):

https://codereview.chromium.org/2699063003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_resources.grd:964: preprocess="true"
On 2017/02/17 19:09:14, dpapad wrote:
> It does not hurt to move this change in this CL, but it is a bit odd, since
the
> other CL is the one adding the first (and only) <if expr> in that file.

Acknowledged.

[Dan Beam, 2017-02-17 19:19:43]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 19:20:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 20:23:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:23:56]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Dan Beam, 2017-02-17 20:54:43]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:55:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 22:36:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 22:36:04]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Dan Beam, 2017-02-18 00:06:21]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-02-18 00:07:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 02:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 02:11:31]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Dan Beam, 2017-02-18 05:45:57]

Description was changed from

==========
MD Settings: fix page to work with vulcanize (when it lands and sticks)

R=dpapad@chromium.org
BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: fix page to work with vulcanize (when it lands and sticks)

R=dpapad@chromium.org
BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========