Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 2699063003: MD Settings: fix page to work with vulcanize (when it lands and sticks) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by Dan Beam (no longer on Chrome)
Modified:
5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-elements_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, michaelpg+watch-elements_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix page to work with vulcanize (when it lands and sticks) R=dpapad@chromium.org BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +1 line, -0 lines 2 comments Download
M ui/webui/resources/cr_elements/icons.html View 1 chunk +4 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 16 (10 generated)
dpapad
LGTM https://codereview.chromium.org/2699063003/diff/1/chrome/browser/resources/settings/settings_resources.grd File chrome/browser/resources/settings/settings_resources.grd (right): https://codereview.chromium.org/2699063003/diff/1/chrome/browser/resources/settings/settings_resources.grd#newcode964 chrome/browser/resources/settings/settings_resources.grd:964: preprocess="true" It does not hurt to move this ...
5 months ago (2017-02-17 19:09:14 UTC) #2
Dan Beam (no longer on Chrome)
https://codereview.chromium.org/2699063003/diff/1/chrome/browser/resources/settings/settings_resources.grd File chrome/browser/resources/settings/settings_resources.grd (right): https://codereview.chromium.org/2699063003/diff/1/chrome/browser/resources/settings/settings_resources.grd#newcode964 chrome/browser/resources/settings/settings_resources.grd:964: preprocess="true" On 2017/02/17 19:09:14, dpapad wrote: > It does ...
5 months ago (2017-02-17 19:19:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699063003/1
5 months ago (2017-02-17 20:55:24 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/121823)
5 months ago (2017-02-17 22:36:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2699063003/1
5 months ago (2017-02-18 00:07:15 UTC) #13
commit-bot: I haz the power
5 months ago (2017-02-18 02:11:31 UTC) #15
Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973