Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: test/file_generator_test.dart

Issue 269823003: Parameterize uri resolution and parsing of options, use package:path (Closed) Base URL: git@github.com:dart-lang/dart-protoc-plugin.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/file_generator_test.dart
diff --git a/test/file_generator_test.dart b/test/file_generator_test.dart
index 8f0da3b5e5df53961831fbe4449404b1b522cf6e..cd0e5b9a82ba37e09482d07170107a2be7bb39ac 100644
--- a/test/file_generator_test.dart
+++ b/test/file_generator_test.dart
@@ -5,9 +5,9 @@
library file_generator_test;
-import 'package:protoc-plugin/src/descriptor.pb.dart';
-import 'package:protoc-plugin/src/plugin.pb.dart';
-import 'package:protoc-plugin/protoc.dart';
+import 'package:protoc_plugin/src/descriptor.pb.dart';
+import 'package:protoc_plugin/src/plugin.pb.dart';
+import 'package:protoc_plugin/protoc.dart';
import 'package:unittest/unittest.dart';
@@ -111,10 +111,10 @@ class PhoneNumber extends GeneratedMessage {
MemoryWriter buffer = new MemoryWriter();
IndentingWriter writer = new IndentingWriter(' ', buffer);
var options =
- new GenerationOptions(
+ parseDefaultGenerationOptions(
new CodeGeneratorRequest(), new CodeGeneratorResponse());
- FileGenerator fg =
- new FileGenerator(fd, null, new GenerationContext(options));
+ FileGenerator fg = new FileGenerator(fd, null,
+ new GenerationContext(options, new DefaultOutputConfiguration()));
fg.generate(writer);
expect(buffer.toString(), expected);
});
@@ -183,10 +183,10 @@ class PhoneNumber extends GeneratedMessage {
MemoryWriter buffer = new MemoryWriter();
IndentingWriter writer = new IndentingWriter(' ', buffer);
var options =
- new GenerationOptions(
+ parseDefaultGenerationOptions(
new CodeGeneratorRequest(), new CodeGeneratorResponse());
- FileGenerator fg =
- new FileGenerator(fd, null, new GenerationContext(options));
+ FileGenerator fg = new FileGenerator(fd, null,
+ new GenerationContext(options, new DefaultOutputConfiguration()));
fg.generate(writer);
expect(buffer.toString(), expected);
});
@@ -237,10 +237,10 @@ class PhoneNumber extends GeneratedMessage {
MemoryWriter buffer = new MemoryWriter();
IndentingWriter writer = new IndentingWriter(' ', buffer);
var options =
- new GenerationOptions(
+ parseDefaultGenerationOptions(
new CodeGeneratorRequest(), new CodeGeneratorResponse());
- FileGenerator fg =
- new FileGenerator(fd, null, new GenerationContext(options));
+ FileGenerator fg = new FileGenerator(fd, null,
+ new GenerationContext(options, new DefaultOutputConfiguration()));
fg.generate(writer);
expect(buffer.toString(), expected);
});
@@ -294,11 +294,10 @@ class PhoneNumber extends GeneratedMessage {
'field_name=PhoneNumber.name|Name_,'
'field_name=PhoneNumber.type|The_type';
var options =
- new GenerationOptions(
+ parseDefaultGenerationOptions(
request, new CodeGeneratorResponse());
- FileGenerator fg =
- new FileGenerator(
- fd, null, new GenerationContext(options));
+ FileGenerator fg = new FileGenerator(fd, null,
+ new GenerationContext(options, new DefaultOutputConfiguration()));
fg.generate(writer);
expect(buffer.toString(), expected);
});
@@ -443,8 +442,10 @@ class M extends GeneratedMessage {
MemoryWriter buffer = new MemoryWriter();
IndentingWriter writer = new IndentingWriter(' ', buffer);
var request = new CodeGeneratorRequest();
- var options = new GenerationOptions(request, new CodeGeneratorResponse());
- var context = new GenerationContext(options);
+ var response = new CodeGeneratorResponse();
+ var options = parseDefaultGenerationOptions(request, response);
+ var context = new GenerationContext(options,
+ new DefaultOutputConfiguration());
new FileGenerator(fd1, null, context);
new FileGenerator(fd2, null, context);
FileGenerator fg = new FileGenerator(fd, null, context);

Powered by Google App Engine
This is Rietveld 408576698