content/child/push_messaging/push_provider.cc - Issue 2697793004: Push API: Validate storage before returning cached subscriptions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/push_messaging/push_provider.cc

Issue 2697793004: Push API: Validate storage before returning cached subscriptions (Closed)

Patch Set: Comment out PUSH_GETREGISTRATION_STATUS_PUBLIC_KEY_UNAVAILABLE Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/push_messaging/push_provider.cc

diff --git a/content/child/push_messaging/push_provider.cc b/content/child/push_messaging/push_provider.cc

index 487af173e45877da0d302676932642516f121ac1..b295235b5806acd61c9570c320d9da1de641bfa8 100644

--- a/content/child/push_messaging/push_provider.cc

+++ b/content/child/push_messaging/push_provider.cc

@@ -62,6 +62,7 @@ blink::WebPushError PushRegistrationStatusToWebPushError(

case PUSH_REGISTRATION_STATUS_INCOGNITO_PERMISSION_DENIED:

case PUSH_REGISTRATION_STATUS_PUBLIC_KEY_UNAVAILABLE:

case PUSH_REGISTRATION_STATUS_MANIFEST_EMPTY_OR_MISSING:

+ case PUSH_REGISTRATION_STATUS_STORAGE_CORRUPT:

error_type = blink::WebPushError::ErrorTypeAbort;

break;

}