Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: content/common/push_messaging.mojom

Issue 2697793004: Push API: Validate storage before returning cached subscriptions (Closed)
Patch Set: Fix include Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/push_messaging/push_provider.cc ('k') | content/common/push_messaging_param_traits.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/push_messaging.mojom
diff --git a/content/common/push_messaging.mojom b/content/common/push_messaging.mojom
index db435ad9a2758457705eac30d0837cb627946e59..2da349bb149a6a34ec34e907c10b71db64e2434a 100644
--- a/content/common/push_messaging.mojom
+++ b/content/common/push_messaging.mojom
@@ -68,12 +68,16 @@ enum PushRegistrationStatus {
// already exists.
SENDER_ID_MISMATCH = 13,
+ // Registration failed because storage was corrupt. It will be retried
+ // automatically after unsubscribing to fix the corruption.
+ STORAGE_CORRUPT = 14,
+
// NOTE: Do not renumber these as that would confuse interpretation of
// previously logged data. When making changes, also update the enum list
// in tools/metrics/histograms/histograms.xml to keep it in sync, and
// update LAST below.
- LAST = SENDER_ID_MISMATCH
+ LAST = STORAGE_CORRUPT
};
enum PushErrorType {
@@ -106,15 +110,18 @@ enum PushGetRegistrationStatus {
// incognito, but we tell JS registration not found to not reveal incognito.
INCOGNITO_REGISTRATION_NOT_FOUND = 4,
- // Registration failed because the public key could not be retrieved.
- PUBLIC_KEY_UNAVAILABLE = 5,
+ // Getting the registration failed because public key could not be retrieved.
+ // PUBLIC_KEY_UNAVAILABLE = 5,
+
+ // Getting the registration failed because storage was corrupt.
+ STORAGE_CORRUPT = 6,
// NOTE: Do not renumber these as that would confuse interpretation of
// previously logged data. When making changes, also update the enum list
// in tools/metrics/histograms/histograms.xml to keep it in sync, and
// update LAST below.
- LAST = PUBLIC_KEY_UNAVAILABLE
+ LAST = STORAGE_CORRUPT
};
enum PushPermissionStatus {
« no previous file with comments | « content/child/push_messaging/push_provider.cc ('k') | content/common/push_messaging_param_traits.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698