components/subresource_filter/content/common/BUILD.gn - Issue 2697363005: Move DocumentSubresourceFilter to core/common.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/common/BUILD.gn

Issue 2697363005: Move DocumentSubresourceFilter to core/common. (Closed)

Patch Set: Address comments from engedy@. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h ('k') | components/subresource_filter/content/common/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/common/BUILD.gn

diff --git a/components/subresource_filter/content/common/BUILD.gn b/components/subresource_filter/content/common/BUILD.gn

index d309bf79d98389f910026f4321d97b11d2188817..15ebae2e006f4de7899a0c85b4222bedc72c64c0 100644

--- a/components/subresource_filter/content/common/BUILD.gn

+++ b/components/subresource_filter/content/common/BUILD.gn

@@ -4,9 +4,6 @@

static_library("common") {

sources = [

- "document_load_statistics.h",

- "document_subresource_filter.cc",

- "document_subresource_filter.h",

"ruleset_dealer.cc",

"ruleset_dealer.h",

"subresource_filter_message_generator.cc",

@@ -17,24 +14,21 @@ static_library("common") {

"//components/subresource_filter/core/common",

"//content/public/common",

"//ipc",

+ "//url",

]

}

source_set("unit_tests") {

testonly = true

sources = [

- "document_subresource_filter_unittest.cc",

"ruleset_dealer_unittest.cc",

]

deps = [

":common",

"//base",

- "//base/test:test_support",

"//components/subresource_filter/core/common",

"//components/subresource_filter/core/common:test_support",

"//testing/gmock",

"//testing/gtest",

- "//third_party/WebKit/public:blink",

- "//url",

]

}