Convert RemoveDataMask from enum to pointers and split it between content and embedder

chrome/browser/chrome_content_browser_client_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
+#include <algorithm>
 #include <list>
 #include <map>
 #include <memory>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/browsing_data/browsing_data_helper.h"
 #include "chrome/browser/browsing_data/browsing_data_remover_factory.h"
 #include "chrome/browser/browsing_data/browsing_data_remover_impl.h"
+#include "chrome/browser/browsing_data/chrome_browsing_data_types.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/search_engines/template_url_service.h"
 #include "components/variations/entropy_provider.h"
 #include "components/variations/variations_associated_data.h"
 #include "components/version_info/version_info.h"
 #include "content/public/browser/browsing_data_filter_builder.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/navigation_entry.h"
@@ skipping 318 matching lines @@
 class MockBrowsingDataRemover : public BrowsingDataRemoverImpl {
  public:
   explicit MockBrowsingDataRemover(content::BrowserContext* context)
       : BrowsingDataRemoverImpl(context) {}
 
   ~MockBrowsingDataRemover() override {
     DCHECK(!expected_calls_.size())
         << "Expectations were set but not verified.";
   }
 
-  void RemoveInternal(const base::Time& delete_begin,
-                      const base::Time& delete_end,
-                      int remove_mask,
-                      int origin_type_mask,
-                      std::unique_ptr<BrowsingDataFilterBuilder> filter_builder,
-                      BrowsingDataRemover::Observer* observer) override {
+  void RemoveInternal(
+      const base::Time& delete_begin,
+      const base::Time& delete_end,
+      const std::set<const content::BrowsingDataType*>& remove_mask,
+      int origin_type_mask,
+      std::unique_ptr<BrowsingDataFilterBuilder> filter_builder,
+      BrowsingDataRemover::Observer* observer) override {
     actual_calls_.emplace_back(delete_begin, delete_end, remove_mask,
                                origin_type_mask, std::move(filter_builder),
                                true /* should_compare_filter */);
 
     // |observer| is not recorded in |actual_calls_| to be compared with
     // expectations, because it's created internally in ClearSiteData() and
     // it's unknown to this. However, it is tested implicitly, because we use
     // it for the completion callback, so an incorrect |observer| will fail
     // the test by waiting for the callback forever.
     DCHECK(observer);
     observer->OnBrowsingDataRemoverDone();
   }
 
-  void ExpectCall(
-      const base::Time& delete_begin,
-      const base::Time& delete_end,
-      int remove_mask,
-      int origin_type_mask,
-      std::unique_ptr<BrowsingDataFilterBuilder> filter_builder) {
+  void ExpectCall(const base::Time& delete_begin,
+                  const base::Time& delete_end,
+                  const std::set<const content::BrowsingDataType*>& remove_mask,
+                  int origin_type_mask,
+                  std::unique_ptr<BrowsingDataFilterBuilder> filter_builder) {
     expected_calls_.emplace_back(delete_begin, delete_end, remove_mask,
                                  origin_type_mask, std::move(filter_builder),
                                  true /* should_compare_filter */);
   }
 
-  void ExpectCallDontCareAboutFilterBuilder(const base::Time& delete_begin,
-                                            const base::Time& delete_end,
-                                            int remove_mask,
-                                            int origin_type_mask) {
+  void ExpectCallDontCareAboutFilterBuilder(
+      const base::Time& delete_begin,
+      const base::Time& delete_end,
+      const std::set<const content::BrowsingDataType*>& remove_mask,
+      int origin_type_mask) {
     expected_calls_.emplace_back(delete_begin, delete_end, remove_mask,
                                  origin_type_mask,
                                  std::unique_ptr<BrowsingDataFilterBuilder>(),
                                  false /* should_compare_filter */);
   }
 
   void VerifyAndClearExpectations() {
     EXPECT_EQ(expected_calls_, actual_calls_);
     expected_calls_.clear();
     actual_calls_.clear();
   }
 
  private:
   class CallParameters {
    public:
-    CallParameters(const base::Time& delete_begin,
-                   const base::Time& delete_end,
-                   int remove_mask,
-                   int origin_type_mask,
-                   std::unique_ptr<BrowsingDataFilterBuilder> filter_builder,
-                   bool should_compare_filter)
+    CallParameters(
+        const base::Time& delete_begin,
+        const base::Time& delete_end,
+        const std::set<const content::BrowsingDataType*>& remove_mask,
+        int origin_type_mask,
+        std::unique_ptr<BrowsingDataFilterBuilder> filter_builder,
+        bool should_compare_filter)
         : delete_begin_(delete_begin),
           delete_end_(delete_end),
           remove_mask_(remove_mask),
           origin_type_mask_(origin_type_mask),
           filter_builder_(std::move(filter_builder)),
           should_compare_filter_(should_compare_filter) {}
     ~CallParameters() {}
 
     bool operator==(const CallParameters& other) const {
       const CallParameters& a = *this;
       const CallParameters& b = other;
 
       if (a.delete_begin_ != b.delete_begin_ ||
           a.delete_end_ != b.delete_end_ ||
           a.remove_mask_ != b.remove_mask_ ||
           a.origin_type_mask_ != b.origin_type_mask_) {
         return false;
       }
 
       if (!a.should_compare_filter_ || !b.should_compare_filter_)
         return true;
       return *a.filter_builder_ == *b.filter_builder_;
     }
 
    private:
     base::Time delete_begin_;
     base::Time delete_end_;
-    int remove_mask_;
+    std::set<const content::BrowsingDataType*> remove_mask_;
     int origin_type_mask_;
     std::unique_ptr<BrowsingDataFilterBuilder> filter_builder_;
     bool should_compare_filter_;
   };
 
   std::list<CallParameters> actual_calls_;
   std::list<CallParameters> expected_calls_;
 };
 
 // Tests for ChromeContentBrowserClient::ClearSiteData().
@@ skipping 26 matching lines @@
   bool finished_;
 };
 
 // Tests that the parameters to ClearBrowsingData() are translated to
 // the correct BrowsingDataRemover::RemoveInternal() operation. The fourth
 // parameter, |filter_builder|, is tested in detail in the RegistrableDomains
 // test below.
 TEST_F(ChromeContentBrowserClientClearSiteDataTest, Parameters) {
   ChromeContentBrowserClient client;
 
+  // no datatypes
+  std::set<const content::BrowsingDataType*> empty_mask;
+
+  // "cookies"
+  const std::set<const content::BrowsingDataType*> domain_scoped_types = {
+      &kBrowsingDataTypeCookies, &kBrowsingDataTypeChannelIDs,
+      &kBrowsingDataTypePluginData,
+  };
+
+  // "storage"
+  std::set<const content::BrowsingDataType*> storage;
+  std::set_difference(BrowsingDataTypeSetSiteData().begin(),
+                      BrowsingDataTypeSetSiteData().end(),
+                      domain_scoped_types.begin(), domain_scoped_types.end(),
+                      std::inserter(storage, storage.begin()));
+
+  // "storage" + "cache"
+  std::set<const content::BrowsingDataType*> storage_and_cache = storage;
+  storage_and_cache.insert(&kBrowsingDataTypeCache);
+
+  // "cookies" + "storage" + "cache"
+  std::set<const content::BrowsingDataType*> all =
+      BrowsingDataTypeSetSiteData();
+  all.insert(&kBrowsingDataTypeCache);
+
   struct TestCase {
     bool cookies;
     bool storage;
     bool cache;
-    int mask;
+    const std::set<const content::BrowsingDataType*> mask;
   } test_cases[] = {
-      {false, false, false, 0},
-      {true, false, false, BrowsingDataRemover::REMOVE_COOKIES |
-                               BrowsingDataRemover::REMOVE_CHANNEL_IDS |
-                               BrowsingDataRemover::REMOVE_PLUGIN_DATA},
-      {false, true, false, BrowsingDataRemover::REMOVE_SITE_DATA &
-                               ~BrowsingDataRemover::REMOVE_COOKIES &
-                               ~BrowsingDataRemover::REMOVE_CHANNEL_IDS &
-                               ~BrowsingDataRemover::REMOVE_PLUGIN_DATA},
-      {false, false, true, BrowsingDataRemover::REMOVE_CACHE},
-      {true, true, false, BrowsingDataRemover::REMOVE_SITE_DATA},
-      {true, false, true, BrowsingDataRemover::REMOVE_COOKIES |
-                              BrowsingDataRemover::REMOVE_CHANNEL_IDS |
-                              BrowsingDataRemover::REMOVE_PLUGIN_DATA |
-                              BrowsingDataRemover::REMOVE_CACHE},
-      {false, true, true, BrowsingDataRemover::REMOVE_CACHE |
-                              (BrowsingDataRemover::REMOVE_SITE_DATA &
-                               ~BrowsingDataRemover::REMOVE_COOKIES &
-                               ~BrowsingDataRemover::REMOVE_CHANNEL_IDS &
-                               ~BrowsingDataRemover::REMOVE_PLUGIN_DATA)},
-      {true, true, true, BrowsingDataRemover::REMOVE_SITE_DATA |
-                             BrowsingDataRemover::REMOVE_CACHE},
+      {false, false, false, empty_mask},
+      {true, false, false, domain_scoped_types},
+      {false, true, false, storage},
+      {false, false, true, {&kBrowsingDataTypeCache}},
+      {true, true, false, BrowsingDataTypeSetSiteData()},
+      {true,
+       false,
+       true,
+       {&kBrowsingDataTypeCookies, &kBrowsingDataTypeChannelIDs,
+        &kBrowsingDataTypePluginData, &kBrowsingDataTypeCache}},
+      {false, true, true, storage_and_cache},
+      {true, true, true, all},
   };
 
   for (unsigned int i = 0; i < arraysize(test_cases); ++i) {
     SCOPED_TRACE(base::StringPrintf("Test case %d", i));
     const TestCase& test_case = test_cases[i];
 
     // We always delete data for all time and all origin types.
     BrowsingDataHelper::OriginTypeMask all_origin_types =
         BrowsingDataHelper::ALL;
 
     // Some data are deleted for the origin and some for the registrable domain.
     // Depending on the chosen datatypes, this might result into one or two
     // calls. In the latter case, the removal mask will be split into two
     // parts - one for the origin deletion and one for the registrable domain.
-    const int domain_scoped_types = BrowsingDataRemover::REMOVE_COOKIES |
-                                    BrowsingDataRemover::REMOVE_CHANNEL_IDS |
-                                    BrowsingDataRemover::REMOVE_PLUGIN_DATA;
-    int registrable_domain_deletion_mask = test_case.mask & domain_scoped_types;
-    int origin_deletion_mask = test_case.mask & ~domain_scoped_types;
+    std::set<const content::BrowsingDataType*> registrable_domain_deletion_mask;
+    std::set_intersection(
+        test_case.mask.begin(), test_case.mask.end(),
+        domain_scoped_types.begin(), domain_scoped_types.end(),
+        std::inserter(registrable_domain_deletion_mask,
+                      registrable_domain_deletion_mask.begin()));
 
-    if (registrable_domain_deletion_mask) {
+    std::set<const content::BrowsingDataType*> origin_deletion_mask;
+    std::set_difference(
+        test_case.mask.begin(), test_case.mask.end(),
+        domain_scoped_types.begin(), domain_scoped_types.end(),
+        std::inserter(origin_deletion_mask, origin_deletion_mask.begin()));
+
+    if (!registrable_domain_deletion_mask.empty()) {
       remover()->ExpectCallDontCareAboutFilterBuilder(
           base::Time(), base::Time::Max(),
           registrable_domain_deletion_mask, all_origin_types);
     }
 
-    if (origin_deletion_mask) {
+    if (!origin_deletion_mask.empty()) {
       remover()->ExpectCallDontCareAboutFilterBuilder(
           base::Time(), base::Time::Max(),
           origin_deletion_mask, all_origin_types);
     }
 
     SetClearingFinished(false);
     client.ClearSiteData(
         profile(), url::Origin(GURL("https://www.example.com")),
         test_case.cookies, test_case.storage, test_case.cache,
         base::Bind(
@@ skipping 51 matching lines @@
   for (const TestCase& test_case : test_cases) {
     SCOPED_TRACE(test_case.origin);
 
     std::unique_ptr<BrowsingDataFilterBuilder>
         registrable_domain_filter_builder(BrowsingDataFilterBuilder::Create(
             BrowsingDataFilterBuilder::WHITELIST));
     registrable_domain_filter_builder->AddRegisterableDomain(test_case.domain);
 
     remover()->ExpectCall(
         base::Time(), base::Time::Max(),
-        BrowsingDataRemover::REMOVE_COOKIES |
-            BrowsingDataRemover::REMOVE_CHANNEL_IDS |
-            BrowsingDataRemover::REMOVE_PLUGIN_DATA,
+        {&kBrowsingDataTypeCookies, &kBrowsingDataTypeChannelIDs,
+         &kBrowsingDataTypePluginData},
         BrowsingDataHelper::ALL, std::move(registrable_domain_filter_builder));
 
     std::unique_ptr<BrowsingDataFilterBuilder> origin_filter_builder(
         BrowsingDataFilterBuilder::Create(
             BrowsingDataFilterBuilder::WHITELIST));
     origin_filter_builder->AddOrigin(url::Origin(GURL(test_case.origin)));
 
-    remover()->ExpectCall(
-        base::Time(), base::Time::Max(),
-        BrowsingDataRemover::REMOVE_CACHE, BrowsingDataHelper::ALL,
-        std::move(origin_filter_builder));
+    remover()->ExpectCall(base::Time(), base::Time::Max(),
+                          {&kBrowsingDataTypeCache}, BrowsingDataHelper::ALL,
+                          std::move(origin_filter_builder));
 
     SetClearingFinished(false);
     client.ClearSiteData(
         profile(), url::Origin(GURL(test_case.origin)), true /* cookies */,
         false /* storage */, true /* cache */,
         base::Bind(
             &ChromeContentBrowserClientClearSiteDataTest::SetClearingFinished,
             base::Unretained(this), true));
     EXPECT_TRUE(IsClearingFinished());
 
@@ skipping 42 matching lines @@
   client.ClearSiteData(
       profile(), origin, true /* cookies */, false /* storage */,
       true /* cache */,
       base::Bind(
           &ChromeContentBrowserClientClearSiteDataTest::SetClearingFinished,
           base::Unretained(this), true));
   EXPECT_TRUE(IsClearingFinished());
 }
 
 }  // namespace