Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: components/ntp_tiles/icon_cacher.h

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)
Patch Set: Fix iOS images and resize only if necessary. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/ntp_tiles/DEPS ('k') | components/ntp_tiles/icon_cacher_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_tiles/icon_cacher.h
diff --git a/components/ntp_tiles/icon_cacher.h b/components/ntp_tiles/icon_cacher.h
index 22beeb6f48c415b3616e15c8c1a94a6b4b9b3c23..d3aff0651c523ecddd93ce0b334d558014cb607b 100644
--- a/components/ntp_tiles/icon_cacher.h
+++ b/components/ntp_tiles/icon_cacher.h
@@ -21,9 +21,12 @@ class IconCacher {
virtual ~IconCacher() = default;
// Fetches the icon if necessary, then invokes |done| with true if it was
- // newly fetched (false if it was already cached or could not be fetched).
+ // newly fetched or a default icon was loaded for the first time.
+ // It's invoked with False if it was already cached or could not be fetched.
+ // The callback will be invoked twice if a default icon was returned in the
+ // first place.
virtual void StartFetch(PopularSites::Site site,
- const base::Callback<void(bool)>& done) = 0;
+ const base::Callback<void(bool)>& icon_available) = 0;
};
} // namespace ntp_tiles
« no previous file with comments | « components/ntp_tiles/DEPS ('k') | components/ntp_tiles/icon_cacher_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698