Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Side by Side Diff: components/ntp_tiles/icon_cacher.h

Issue 2695713004: Add baked-in favicons for default popular sites on NTP (Closed)
Patch Set: Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/ntp_tiles/DEPS ('k') | components/ntp_tiles/icon_cacher_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NTP_TILES_ICON_CACHER_H_ 5 #ifndef COMPONENTS_NTP_TILES_ICON_CACHER_H_
6 #define COMPONENTS_NTP_TILES_ICON_CACHER_H_ 6 #define COMPONENTS_NTP_TILES_ICON_CACHER_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "components/ntp_tiles/popular_sites.h" 9 #include "components/ntp_tiles/popular_sites.h"
10 10
11 namespace ntp_tiles { 11 namespace ntp_tiles {
12 12
13 // Ensures that a Popular Sites icon is cached, downloading and saving it if 13 // Ensures that a Popular Sites icon is cached, downloading and saving it if
14 // not. 14 // not.
15 // 15 //
16 // Does not provide any way to get a fetched favicon; use the FaviconService for 16 // Does not provide any way to get a fetched favicon; use the FaviconService for
17 // that. All this interface guarantees is that FaviconService will be able to 17 // that. All this interface guarantees is that FaviconService will be able to
18 // get you an icon (if it exists). 18 // get you an icon (if it exists).
19 class IconCacher { 19 class IconCacher {
20 public: 20 public:
21 virtual ~IconCacher() = default; 21 virtual ~IconCacher() = default;
22 22
23 // Fetches the icon if necessary, then invokes |done| with true if it was 23 // Fetches the icon if necessary. It invokes |icon_available| if a new icon
24 // newly fetched (false if it was already cached or could not be fetched). 24 // was fetched. This is the only required callback.
25 // If there are preliminary icons (e.g. provided by static resources), the
26 // |preliminary_icon_available| callback will be invoked additionally.
27 // TODO(fhorschig): In case we keep these, make them OnceClosures.
25 virtual void StartFetch(PopularSites::Site site, 28 virtual void StartFetch(PopularSites::Site site,
26 const base::Callback<void(bool)>& done) = 0; 29 const base::Closure& icon_available,
30 const base::Closure& preliminary_icon_available) = 0;
27 }; 31 };
28 32
29 } // namespace ntp_tiles 33 } // namespace ntp_tiles
30 34
31 #endif // COMPONENTS_NTP_TILES_ICON_CACHER_H_ 35 #endif // COMPONENTS_NTP_TILES_ICON_CACHER_H_
OLDNEW
« no previous file with comments | « components/ntp_tiles/DEPS ('k') | components/ntp_tiles/icon_cacher_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698