Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: components/favicon/ios/web_favicon_driver.mm

Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons (Closed)
Patch Set: Rebased Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/ios/web_favicon_driver.h ('k') | ios/chrome/browser/reading_list/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/ios/web_favicon_driver.mm
diff --git a/components/favicon/ios/web_favicon_driver.mm b/components/favicon/ios/web_favicon_driver.mm
index 889d2ed96e4840e7fff4346f7948556fd2a0ddba..0bde34eb1fbcd9fa0c4ecd751625e2d41fb61125 100644
--- a/components/favicon/ios/web_favicon_driver.mm
+++ b/components/favicon/ios/web_favicon_driver.mm
@@ -38,14 +38,13 @@ namespace favicon {
void WebFaviconDriver::CreateForWebState(
web::WebState* web_state,
FaviconService* favicon_service,
- history::HistoryService* history_service,
- bookmarks::BookmarkModel* bookmark_model) {
+ history::HistoryService* history_service) {
if (FromWebState(web_state))
return;
- web_state->SetUserData(UserDataKey(), base::WrapUnique(new WebFaviconDriver(
- web_state, favicon_service,
- history_service, bookmark_model)));
+ web_state->SetUserData(UserDataKey(),
+ base::WrapUnique(new WebFaviconDriver(
+ web_state, favicon_service, history_service)));
}
void WebFaviconDriver::FetchFavicon(const GURL& page_url,
@@ -133,10 +132,9 @@ void WebFaviconDriver::OnFaviconUpdated(
WebFaviconDriver::WebFaviconDriver(web::WebState* web_state,
FaviconService* favicon_service,
- history::HistoryService* history_service,
- bookmarks::BookmarkModel* bookmark_model)
+ history::HistoryService* history_service)
: web::WebStateObserver(web_state),
- FaviconDriverImpl(favicon_service, history_service, bookmark_model),
+ FaviconDriverImpl(favicon_service, history_service),
image_fetcher_(web_state->GetBrowserState()->GetRequestContext()) {}
WebFaviconDriver::~WebFaviconDriver() {
« no previous file with comments | « components/favicon/ios/web_favicon_driver.h ('k') | ios/chrome/browser/reading_list/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698