Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: components/favicon/ios/web_favicon_driver.h

Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons (Closed)
Patch Set: Rebased Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/favicon/core/favicon_handler_unittest.cc ('k') | components/favicon/ios/web_favicon_driver.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/ios/web_favicon_driver.h
diff --git a/components/favicon/ios/web_favicon_driver.h b/components/favicon/ios/web_favicon_driver.h
index 8e6abd376d5d32c9ee0692511c46c12c86429e10..93acc0dfea695213d8d03b517f38a9a4206ede82 100644
--- a/components/favicon/ios/web_favicon_driver.h
+++ b/components/favicon/ios/web_favicon_driver.h
@@ -28,8 +28,7 @@ class WebFaviconDriver : public web::WebStateObserver,
static void CreateForWebState(web::WebState* web_state,
FaviconService* favicon_service,
- history::HistoryService* history_service,
- bookmarks::BookmarkModel* bookmark_model);
+ history::HistoryService* history_service);
// FaviconDriver implementation.
void FetchFavicon(const GURL& page_url, bool is_same_document) override;
@@ -56,8 +55,7 @@ class WebFaviconDriver : public web::WebStateObserver,
WebFaviconDriver(web::WebState* web_state,
FaviconService* favicon_service,
- history::HistoryService* history_service,
- bookmarks::BookmarkModel* bookmark_model);
+ history::HistoryService* history_service);
// web::WebStateObserver implementation.
void FaviconUrlUpdated(
« no previous file with comments | « components/favicon/core/favicon_handler_unittest.cc ('k') | components/favicon/ios/web_favicon_driver.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698