Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: components/favicon/content/content_favicon_driver.cc

Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons (Closed)
Patch Set: Rebased Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/content/content_favicon_driver.cc
diff --git a/components/favicon/content/content_favicon_driver.cc b/components/favicon/content/content_favicon_driver.cc
index 97d3501077eeb2a5c8eb57f1b4133a2172fea8b6..c646c6df8211899cabbac64e2b5fdde3b901378d 100644
--- a/components/favicon/content/content_favicon_driver.cc
+++ b/components/favicon/content/content_favicon_driver.cc
@@ -43,18 +43,16 @@ void ExtractManifestIcons(
void ContentFaviconDriver::CreateForWebContents(
content::WebContents* web_contents,
FaviconService* favicon_service,
- history::HistoryService* history_service,
- bookmarks::BookmarkModel* bookmark_model) {
+ history::HistoryService* history_service) {
if (FromWebContents(web_contents))
return;
web_contents->SetUserData(
- UserDataKey(),
- base::WrapUnique(new ContentFaviconDriver(
- web_contents, favicon_service, history_service, bookmark_model)));
+ UserDataKey(), base::WrapUnique(new ContentFaviconDriver(
+ web_contents, favicon_service, history_service)));
}
-void ContentFaviconDriver::SaveFavicon() {
+void ContentFaviconDriver::SaveFaviconEvenIfInIncognito() {
content::NavigationEntry* entry =
web_contents()->GetController().GetLastCommittedEntry();
if (!entry)
@@ -115,11 +113,9 @@ GURL ContentFaviconDriver::GetActiveURL() {
ContentFaviconDriver::ContentFaviconDriver(
content::WebContents* web_contents,
FaviconService* favicon_service,
- history::HistoryService* history_service,
- bookmarks::BookmarkModel* bookmark_model)
+ history::HistoryService* history_service)
: content::WebContentsObserver(web_contents),
- FaviconDriverImpl(favicon_service, history_service, bookmark_model) {
-}
+ FaviconDriverImpl(favicon_service, history_service) {}
ContentFaviconDriver::~ContentFaviconDriver() {
}
« no previous file with comments | « components/favicon/content/content_favicon_driver.h ('k') | components/favicon/content/content_favicon_driver_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698