Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: chrome/browser/favicon/favicon_utils.cc

Issue 2694333002: Fix leaking page visits in incognito mode via bookmarked favicons (Closed)
Patch Set: Rebased Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_utils.cc
diff --git a/chrome/browser/favicon/favicon_utils.cc b/chrome/browser/favicon/favicon_utils.cc
index f44f5a3aeb1e42910027012487264947588a7d4d..ce8f0b43b29b1f797826f942078fce73a3182fc0 100644
--- a/chrome/browser/favicon/favicon_utils.cc
+++ b/chrome/browser/favicon/favicon_utils.cc
@@ -4,7 +4,6 @@
#include "chrome/browser/favicon/favicon_utils.h"
-#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/history/history_service_factory.h"
#include "chrome/browser/profiles/profile.h"
@@ -38,11 +37,11 @@ void CreateContentFaviconDriverForWebContents(
Profile::FromBrowserContext(web_contents->GetBrowserContext())
->GetOriginalProfile();
return ContentFaviconDriver::CreateForWebContents(
- web_contents, FaviconServiceFactory::GetForProfile(
- original_profile, ServiceAccessType::IMPLICIT_ACCESS),
- HistoryServiceFactory::GetForProfile(original_profile,
+ web_contents,
+ FaviconServiceFactory::GetForProfile(original_profile,
ServiceAccessType::IMPLICIT_ACCESS),
- BookmarkModelFactory::GetForBrowserContextIfExists(original_profile));
+ HistoryServiceFactory::GetForProfile(original_profile,
+ ServiceAccessType::IMPLICIT_ACCESS));
}
bool ShouldDisplayFavicon(content::WebContents* web_contents) {
« no previous file with comments | « no previous file | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698