Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1549)

Unified Diff: services/resource_coordinator/memory/coordinator/coordinator_impl.h

Issue 2694083005: memory-infra: Finish moving memory_infra from TracingController (Closed)
Patch Set: style: auto must not deduce to raw pointer Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/memory/coordinator/coordinator_impl.h
diff --git a/services/resource_coordinator/memory/coordinator/coordinator_impl.h b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
index 80ce6aee23efcad2ee470e69f654ec0a09ca1e77..69f63cda3ab80b9275d197295d7b95b224a5faec 100644
--- a/services/resource_coordinator/memory/coordinator/coordinator_impl.h
+++ b/services/resource_coordinator/memory/coordinator/coordinator_impl.h
@@ -11,7 +11,7 @@
#include "base/lazy_instance.h"
#include "base/memory/ref_counted.h"
-#include "base/threading/thread_checker.h"
+#include "base/single_thread_task_runner.h"
#include "base/trace_event/memory_dump_request_args.h"
#include "mojo/public/cpp/bindings/binding.h"
#include "mojo/public/cpp/bindings/binding_set.h"
@@ -22,13 +22,15 @@ namespace memory_instrumentation {
class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
public:
- static CoordinatorImpl* GetInstance();
+ static CoordinatorImpl* GetInstance(
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner);
// Coordinator
void BindCoordinatorRequest(mojom::CoordinatorRequest) override;
private:
- friend class CoordinatorImplTest; // For testing
+ friend std::default_delete<CoordinatorImpl>; // For testing
+ friend class CoordinatorImplTest; // For testing
friend struct base::DefaultLazyInstanceTraits<CoordinatorImpl>;
struct QueuedMemoryDumpRequest {
@@ -42,6 +44,10 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
CoordinatorImpl();
~CoordinatorImpl() override;
+ void Initialize(scoped_refptr<base::SingleThreadTaskRunner> task_runner);
+ void InitializeForTest(
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner);
+
// mojom::Coordinator
void RegisterProcessLocalDumpManager(
mojom::ProcessLocalDumpManagerPtr process_manager) override;
@@ -78,7 +84,7 @@ class CoordinatorImpl : public Coordinator, public mojom::Coordinator {
int failed_memory_dump_count_;
std::list<QueuedMemoryDumpRequest> queued_memory_dump_requests_;
- base::ThreadChecker thread_checker_;
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
DISALLOW_COPY_AND_ASSIGN(CoordinatorImpl);
};
« no previous file with comments | « services/resource_coordinator/BUILD.gn ('k') | services/resource_coordinator/memory/coordinator/coordinator_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698