base/task_scheduler/scheduler_worker_pool_impl.h - Issue 2692863012: SchedulerWorker Refcounting for Destruction in Production

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl.h

Issue 2692863012: SchedulerWorker Refcounting for Destruction in Production (Closed)

Patch Set: Remove Last Vestiges of std::unique_ptr SchedulerWorker Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/task_scheduler/scheduler_worker_pool_impl.h

diff --git a/base/task_scheduler/scheduler_worker_pool_impl.h b/base/task_scheduler/scheduler_worker_pool_impl.h

index 253f2020c9a72ede22a02e27d36d917b196664e1..d4b8440ce86c1a1666a5339a000cdcffe9b19bcc 100644

--- a/base/task_scheduler/scheduler_worker_pool_impl.h

+++ b/base/task_scheduler/scheduler_worker_pool_impl.h

@@ -145,7 +145,7 @@ class BASE_EXPORT SchedulerWorkerPoolImpl : public SchedulerWorkerPool {

// All worker owned by this worker pool. Only modified during initialization

// of the worker pool.

- std::vector<std::unique_ptr<SchedulerWorker>> workers_;

+ std::vector<scoped_refptr<SchedulerWorker>> workers_;

// Synchronizes access to |next_worker_index_|.

SchedulerLock next_worker_index_lock_;