[Android History] Even more polish

[Android History] Even more polish

 * Add "Copied" snackbar and clear selection when link copied
 * Tweak date header top/bottom margin
 * Fix margin around privacy disclaimers/clear browsing data button

BUG=654071, 691758, 691755
Review-Url: https://codereview.chromium.org/2691373004
Cr-Commit-Position: refs/heads/master@{#451359}
Committed: https://chromium.googlesource.com/chromium/src/+/9e2a2c4db708e93db250dc00c6b6899a3dad8229

[Theresa, 2017-02-15 18:38:22]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2017-02-15 18:38:22]

ptal when convenient

[Theresa, 2017-02-15 18:38:25]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 18:39:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 20:45:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 20:45:50]

Dry run: This issue passed the CQ dry run.

[Theresa, 2017-02-15 21:41:05]

https://codereview.chromium.org/2691373004/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/history_item_view.xml (right):

https://codereview.chromium.org/2691373004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/history_item_view.xml:20:
android:paddingStart="1dp"
This should be moved to HistoryItemView above since this LinearLayout's end
padding is programatically set based on whether the remove icon is present.

[Theresa, 2017-02-15 23:16:16]

https://codereview.chromium.org/2691373004/diff/1/chrome/android/java/res/lay...
File chrome/android/java/res/layout/history_item_view.xml (right):

https://codereview.chromium.org/2691373004/diff/1/chrome/android/java/res/lay...
chrome/android/java/res/layout/history_item_view.xml:20:
android:paddingStart="1dp"
On 2017/02/15 21:41:04, Theresa wrote:
> This should be moved to HistoryItemView above since this LinearLayout's end
> padding is programatically set based on whether the remove icon is present.

Done.

[Theresa, 2017-02-16 16:53:54]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 16:54:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 17:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 17:58:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gone, 2017-02-16 19:29:16]

More or less lgtm

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java
(right):

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java:387:
boolean privacyDisclaimersVisible =
arePrivacyDisclaimersVisible?  This function already references is & has.

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
(right):

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java:207:
((SnackbarManageable) mActivity).getSnackbarManager().showSnackbar(snackbar);
Any reason we're using a snackbar instead of a toast?

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:2289: Copied
Move to generic section at top?

[Theresa, 2017-02-16 19:59:09]

twellington@chromium.org changed reviewers:
+ holte@chromium.org

[Theresa, 2017-02-16 19:59:10]

+holte@ for histograms.xml

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java
(right):

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryAdapter.java:387:
boolean privacyDisclaimersVisible =
On 2017/02/16 19:29:16, dfalcantara (load balance plz) wrote:
> arePrivacyDisclaimersVisible?  This function already references is & has.

Done.

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java
(right):

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java:207:
((SnackbarManageable) mActivity).getSnackbarManager().showSnackbar(snackbar);
On 2017/02/16 19:29:16, dfalcantara (load balance plz) wrote:
> Any reason we're using a snackbar instead of a toast?

I asked UX if we could use a toast and they said no. They were trying to achieve
consistency with the "Bookmarked" snackbar that shows up when you bookmark
something.

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2691373004/diff/40001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:2289: Copied
On 2017/02/16 19:29:16, dfalcantara (load balance plz) wrote:
> Move to generic section at top?

Done.

[Theresa, 2017-02-16 19:59:14]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 20:00:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 22:16:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 22:16:22]

Dry run: This issue passed the CQ dry run.

[Steven Holte, 2017-02-17 19:24:49]

lgtm

[Theresa, 2017-02-17 19:27:53]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2017-02-17 19:27:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2691373004/#ps60001
(title: "[Android History] Even more polish")

[commit-bot: I haz the power, 2017-02-17 19:29:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 19:53:54]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487359673755940,
"parent_rev": "df7686e843360e2ae174bda45648708b59653830", "commit_rev":
"9e2a2c4db708e93db250dc00c6b6899a3dad8229"}

[commit-bot: I haz the power, 2017-02-17 19:54:48]

Description was changed from

==========
[Android History] Even more polish

 * Add "Copied" snackbar and clear selection when link copied
 * Tweak date header top/bottom margin
 * Fix margin around privacy disclaimers/clear browsing data button

BUG=654071,691758,691755
==========

to

==========
[Android History] Even more polish

 * Add "Copied" snackbar and clear selection when link copied
 * Tweak date header top/bottom margin
 * Fix margin around privacy disclaimers/clear browsing data button

BUG=654071,691758,691755

Review-Url: https://codereview.chromium.org/2691373004
Cr-Commit-Position: refs/heads/master@{#451359}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e2a2c4db708e93db250dc00c6b6...
==========

[commit-bot: I haz the power, 2017-02-17 19:54:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9e2a2c4db708e93db250dc00c6b6...