Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2689253002: cc: Add layout test cases for mask tiling. (Closed)

Created:
3 years, 10 months ago by sunxd
Modified:
3 years, 10 months ago
Reviewers:
trchen, enne (OOO)
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add layout test cases for mask tiling. Add the layout test cases prior to mask tiling patch landing so that we can have rebaselined expected results when mask tiling lands. The tests mainly cover the following cases: * basic border radius * border-radius with scrolling (applying textures from correct offset) * border-radius with scale transforms (coverage space conversion) * border-radius with filters (single texture masks) * border-radius with demoting filters (single -> multi or vice-versa) BUG=567293 Review-Url: https://codereview.chromium.org/2689253002 Cr-Commit-Position: refs/heads/master@{#452517} Committed: https://chromium.googlesource.com/chromium/src/+/d95453989b7c14ae3c9012d04be75f3ffc012d48

Patch Set 1 #

Patch Set 2 : Format changes. #

Patch Set 3 : Oops, forgot to delete non-sense comments. #

Patch Set 4 : Rebase #

Patch Set 5 : Remove test expectations. #

Patch Set 6 : Test rebaseline. #

Total comments: 14

Patch Set 7 : Add mirror main thread cases. #

Patch Set 8 : Rebase #

Patch Set 9 : Modify the underlying blur picture. #

Patch Set 10 : Add test expectations. #

Patch Set 11 : Rebaseline virtual/prefer_compositing_to_lcd_text tests. #

Total comments: 1

Messages

Total messages: 33 (18 generated)
sunxd
Hello, I decide to land the layout tests first to get an auto rebaseline. But ...
3 years, 10 months ago (2017-02-13 21:22:39 UTC) #4
enne (OOO)
Sounds like a good approach. I'll let trchen review this. Would it make sense to ...
3 years, 10 months ago (2017-02-14 17:28:16 UTC) #5
trchen
Quick question: how are these tests specific to tiled mask? That said, more test coverage ...
3 years, 10 months ago (2017-02-14 22:59:49 UTC) #14
sunxd
On 2017/02/14 22:59:49, trchen wrote: > Quick question: how are these tests specific to tiled ...
3 years, 10 months ago (2017-02-16 17:26:52 UTC) #15
sunxd
I'm going to remove the to-blur.jpg. But here is the test rebaseline.
3 years, 10 months ago (2017-02-16 17:27:24 UTC) #16
trchen
The tests could use some clean up. I think the border-radius-based tests should be moved ...
3 years, 10 months ago (2017-02-16 23:46:51 UTC) #17
trchen
Oops I just realized I didn't publish my comments. Here's the clean-up I meant to ...
3 years, 10 months ago (2017-02-18 01:31:37 UTC) #18
sunxd
I've applied all the comments, though rebaseline is still in process. https://codereview.chromium.org/2689253002/diff/100001/third_party/WebKit/LayoutTests/compositing/masks/mask-with-added-filters.html File third_party/WebKit/LayoutTests/compositing/masks/mask-with-added-filters.html (right): ...
3 years, 10 months ago (2017-02-22 22:30:59 UTC) #19
trchen
Thank you! These are some nice solid tests. lgtm On 2017/02/22 22:30:59, sunxd wrote: > ...
3 years, 10 months ago (2017-02-22 22:46:00 UTC) #20
sunxd
On 2017/02/22 22:46:00, trchen wrote: > Thank you! These are some nice solid tests. lgtm ...
3 years, 10 months ago (2017-02-22 23:09:30 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689253002/180001
3 years, 10 months ago (2017-02-22 23:10:38 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/387856)
3 years, 10 months ago (2017-02-23 00:17:41 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689253002/200001
3 years, 10 months ago (2017-02-23 15:35:09 UTC) #29
commit-bot: I haz the power
Committed patchset #11 (id:200001) as https://chromium.googlesource.com/chromium/src/+/d95453989b7c14ae3c9012d04be75f3ffc012d48
3 years, 10 months ago (2017-02-23 16:36:42 UTC) #32
trchen
3 years, 10 months ago (2017-02-23 23:12:21 UTC) #33
Message was sent while issue was closed.
https://codereview.chromium.org/2689253002/diff/200001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/compositing/masks/mask-with-added-filters.html
(right):

https://codereview.chromium.org/2689253002/diff/200001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/compositing/masks/mask-with-added-filters.html:34:
<p>Testing masks with filters on compositing layers. Left and right columns
should look almost the same, composited filter look slightly different.</p>
By the way the composited one incorrectly stretched the mask. I believe your
tiled mask CL will fix it on the way. Also I don't think there's an existing
crbug for this bug. Could you file one?

Powered by Google App Engine
This is Rietveld 408576698