Fix crash when drag moving URLs in chrome://settings/startup.

Fix crash when drag moving URLs in chrome://settings/startup.

This isn't really a proper fix because drag move is broken in this case.
However, I'm not familiar enough with the WebUI JS to understand why
it's passing an empty list of selected indices even though it shouldn't.

BUG=302284

[Dan Beam, 2013-10-14 18:08:06]

If we can't figure this out pretty soon we can paper over it.

https://codereview.chromium.org/26887002/diff/1/chrome/browser/custom_home_pa...
File chrome/browser/custom_home_pages_table_model.cc (right):

https://codereview.chromium.org/26887002/diff/1/chrome/browser/custom_home_pa...
chrome/browser/custom_home_pages_table_model.cc:102: // get confused and pass us
an empty list of selected indices to drag move.
Are you sure it's the WebUI's fault? This can only be called from C++ as it's
not a message handling method.

https://codereview.chromium.org/26887002/diff/1/chrome/browser/custom_home_pa...
chrome/browser/custom_home_pages_table_model.cc:104: if (index_list.empty())
NOTREACHED();

[Dan Beam, 2013-10-20 20:28:59]

i wasn't able to go to this last week, so lgtm if you want to paper

[commit-bot: I haz the power, 2013-10-25 07:53:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dcheng@chromium.org/26887002/1

[commit-bot: I haz the power, 2013-10-25 08:27:31]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[dcheng, 2013-10-25 08:38:13]

+thakis for OWNERS stamp.

[Nico, 2013-10-25 21:33:46]

Is it possible to test this, so that when someone fixes the real issue they have
an easy way to check they fixed it correctly?

[dcheng, 2013-10-28 07:35:25]

On 2013/10/25 21:33:46, Nico wrote:
> Is it possible to test this, so that when someone fixes the real issue they
have
> an easy way to check they fixed it correctly?

Unfortunately, I don't know of a way to automate testing since it'd require
automating the WebUI interface... hopefully someone can correct me if I'm wrong.

[(unused - use chromium), 2013-10-28 15:25:18]

On Mon, Oct 28, 2013 at 12:35 AM, <dcheng@chromium.org> wrote:

> On 2013/10/25 21:33:46, Nico wrote:
>
>> Is it possible to test this, so that when someone fixes the real issue
>> they
>>
> have
>
>> an easy way to check they fixed it correctly?
>>
>
> Unfortunately, I don't know of a way to automate testing since it'd require
> automating the WebUI interface... hopefully someone can correct me if I'm
> wrong.
>

Isn't this described in
http://www.chromium.org/Home/domui-testing/webui-browser_tests ? (not sure,
I've only done this once iirc and it was a while ago)


>
>
https://codereview.chromium.**org/26887002/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[(unused - use chromium), 2013-10-28 22:32:23]

Looks like dbean has a different fix for this out here:
https://codereview.chromium.org/47033003/


On Mon, Oct 28, 2013 at 8:25 AM, Nico Weber <thakis@google.com> wrote:

> On Mon, Oct 28, 2013 at 12:35 AM, <dcheng@chromium.org> wrote:
>
>> On 2013/10/25 21:33:46, Nico wrote:
>>
>>> Is it possible to test this, so that when someone fixes the real issue
>>> they
>>>
>> have
>>
>>> an easy way to check they fixed it correctly?
>>>
>>
>> Unfortunately, I don't know of a way to automate testing since it'd
>> require
>> automating the WebUI interface... hopefully someone can correct me if I'm
>> wrong.
>>
>
> Isn't this described in
> http://www.chromium.org/Home/domui-testing/webui-browser_tests ? (not
> sure, I've only done this once iirc and it was a while ago)
>
>
>>
>>
https://codereview.chromium.**org/26887002/<https://codereview.chromium.org/2...
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dan Beam, 2013-10-28 22:57:24]

On 2013/10/28 22:32:23, thakis wrote:
> Looks like dbean has a different fix for this out here:
> https://codereview.chromium.org/47033003/

yes, have been talking with dcheng@ about this

> 
> 
> On Mon, Oct 28, 2013 at 8:25 AM, Nico Weber <mailto:thakis@google.com> wrote:
> 
> > On Mon, Oct 28, 2013 at 12:35 AM, <mailto:dcheng@chromium.org> wrote:
> >
> >> On 2013/10/25 21:33:46, Nico wrote:
> >>
> >>> Is it possible to test this, so that when someone fixes the real issue
> >>> they
> >>>
> >> have
> >>
> >>> an easy way to check they fixed it correctly?
> >>>
> >>
> >> Unfortunately, I don't know of a way to automate testing since it'd
> >> require
> >> automating the WebUI interface... hopefully someone can correct me if I'm
> >> wrong.
> >>
> >
> > Isn't this described in
> > http://www.chromium.org/Home/domui-testing/webui-browser_tests ? (not
> > sure, I've only done this once iirc and it was a while ago)
> >
> >
> >>
> >>
>
https://codereview.chromium.**org/26887002/%3Chttps://codereview.chromium.org...>
> >>
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Dan Beam, 2013-11-04 20:44:35]

On 2013/10/28 22:57:24, Dan Beam wrote:
> On 2013/10/28 22:32:23, thakis wrote:
> > Looks like dbean has a different fix for this out here:
> > https://codereview.chromium.org/47033003/
> 
> yes, have been talking with dcheng@ about this
> 
> > 
> > 
> > On Mon, Oct 28, 2013 at 8:25 AM, Nico Weber <mailto:thakis@google.com>
wrote:
> > 
> > > On Mon, Oct 28, 2013 at 12:35 AM, <mailto:dcheng@chromium.org> wrote:
> > >
> > >> On 2013/10/25 21:33:46, Nico wrote:
> > >>
> > >>> Is it possible to test this, so that when someone fixes the real issue
> > >>> they
> > >>>
> > >> have
> > >>
> > >>> an easy way to check they fixed it correctly?
> > >>>
> > >>
> > >> Unfortunately, I don't know of a way to automate testing since it'd
> > >> require
> > >> automating the WebUI interface... hopefully someone can correct me if I'm
> > >> wrong.
> > >>
> > >
> > > Isn't this described in
> > > http://www.chromium.org/Home/domui-testing/webui-browser_tests ? (not
> > > sure, I've only done this once iirc and it was a while ago)
> > >
> > >
> > >>
> > >>
> >
>
https://codereview.chromium.**org/26887002/%253Chttps://codereview.chromium.o...>
> > >>
> > >
> > >
> > 
> > To unsubscribe from this group and stop receiving emails from it, send an
> email
> > to mailto:chromium-reviews+unsubscribe@chromium.org.

as dcheng@ is OOO and we'd probably still like to merge a 1-liner to M31 branch
I've picked this up here:
https://chromiumcodereview.appspot.com/52823006/

[Dan Beam, 2013-11-06 04:16:24]

we can probably close this now