Issue 26873002: Remove BaseLoad/StoreStub compilers, and the stub-cache interface duplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26873002: Remove BaseLoad/StoreStub compilers, and the stub-cache interface duplication. (Closed)

Created:
7 years, 2 months ago by Toon Verwaest

Modified:
7 years, 2 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove BaseLoad/StoreStub compilers, and the stub-cache interface duplication. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17165

Patch Set 1 #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+342 lines, -754 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	13 chunks	+44 lines, -43 lines	0 comments	Download
M	src/builtins.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	12 chunks	+44 lines, -48 lines	0 comments	Download
M	src/ic.h	View	3 chunks	+5 lines, -8 lines	1 comment	Download
M	src/ic.cc	View	15 chunks	+76 lines, -165 lines	0 comments	Download
M	src/stub-cache.h	View	10 chunks	+93 lines, -204 lines	0 comments	Download
M	src/stub-cache.cc	View	15 chunks	+37 lines, -245 lines	1 comment	Download
M	src/x64/stub-cache-x64.cc	View	13 chunks	+41 lines, -40 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://chromiumcodereview.appspot.com/26873002/diff/1/src/ic.h File src/ic.h (right): https://chromiumcodereview.appspot.com/26873002/diff/1/src/ic.h#newcode440 src/ic.h:440: Representation::Tagged()); Indent to 4 spaces. https://chromiumcodereview.appspot.com/26873002/diff/1/src/stub-cache.cc File src/stub-cache.cc ...

7 years, 2 months ago (2013-10-11 13:37:50 UTC) #2

Toon Verwaest

7 years, 2 months ago (2013-10-11 14:05:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17165 (presubmit successful).

Expand Messages | Collapse Messages