Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 2684103005: Allow media track switching. (Closed)

Created:
3 years, 10 months ago by servolk
Modified:
3 years, 8 months ago
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow media track switching. This CL allows Audio and VideoRenderer to be reinitialized in the flushed/stopped states and allows switching between different audio and video tracks during playback (but only a single track of each type may be active at a time). BUG=487288 Review-Url: https://codereview.chromium.org/2684103005 Cr-Commit-Position: refs/heads/master@{#463658} Committed: https://chromium.googlesource.com/chromium/src/+/16e8bdf82977fa9734263248666543e204a930a4

Patch Set 1 #

Patch Set 2 : fix initial track selection #

Patch Set 3 : Add tests #

Patch Set 4 : Rebase + more tests and fixes #

Patch Set 5 : rebase #

Patch Set 6 : Log a warning when ignoring enabled audio tracks after the first one #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : Restore CreateRenderer in pipeline_integration_test.cc #

Total comments: 8

Patch Set 10 : Allow mojo media interfaces to be obtained from any thread #

Patch Set 11 : CR feedback #

Total comments: 10

Patch Set 12 : rebase #

Patch Set 13 : Create MediaInterfaceProvider weak ptr on the main thread #

Patch Set 14 : Added a LayoutTest for media track switching #

Total comments: 32

Patch Set 15 : CR feedback #

Total comments: 20

Patch Set 16 : CR feedback #

Patch Set 17 : Postpone Flush while handling stream status changes #

Patch Set 18 : Added a note in GpuMemoryBufferVideoFramePool about memory buffers being refcounted #

Patch Set 19 : rebase / resolve conflict #

Total comments: 4

Patch Set 20 : Updated GpuMemoryBufferVideoFramePool comment #

Patch Set 21 : Updated GpuMemoryBufferVideoFramePool comment #

Total comments: 25

Patch Set 22 : More unit tests + CR feedback #

Patch Set 23 : Updated log message #

Total comments: 8

Patch Set 24 : Fixed comment #

Patch Set 25 : Rearrange methods to match declaration order #

Patch Set 26 : rebase #

Patch Set 27 : Properly handle track status changes in FLUSHED state #

Total comments: 11

Patch Set 28 : rebase #

Patch Set 29 : Added comments in RestartA/VRenderer #

Patch Set 30 : CR feedback #

Patch Set 31 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+903 lines, -258 lines) Patch
M content/renderer/media/media_interface_provider.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/media/media_interface_provider.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 3 chunks +15 lines, -5 lines 0 comments Download
M media/base/audio_renderer.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
M media/base/fake_audio_renderer_sink.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_renderer.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 1 chunk +8 lines, -3 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +8 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 2 chunks +15 lines, -0 lines 0 comments Download
M media/renderers/audio_renderer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +16 lines, -9 lines 0 comments Download
M media/renderers/audio_renderer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 5 chunks +17 lines, -7 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 1 2 13 chunks +75 lines, -48 lines 0 comments Download
M media/renderers/default_renderer_factory.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +5 lines, -0 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +18 lines, -2 lines 0 comments Download
M media/renderers/renderer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 6 chunks +42 lines, -7 lines 0 comments Download
M media/renderers/renderer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 8 chunks +199 lines, -64 lines 0 comments Download
M media/renderers/renderer_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 4 chunks +216 lines, -4 lines 0 comments Download
M media/renderers/video_renderer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +23 lines, -14 lines 0 comments Download
M media/renderers/video_renderer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +21 lines, -11 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 9 chunks +49 lines, -25 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +32 lines, -5 lines 0 comments Download
M media/test/pipeline_integration_test_base.h View 1 2 3 4 5 6 5 chunks +15 lines, -21 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 8 chunks +51 lines, -29 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/media/avtrack/track-switching.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +55 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/media/content/multitrack-3video-2audio.webm View 1 2 3 4 5 6 7 8 9 10 11 12 13 Binary file 0 comments Download

Messages

Total messages: 192 (124 generated)
servolk
3 years, 9 months ago (2017-03-16 20:45:11 UTC) #38
DaleCurtis
Do you have a demo page for this functionality? I'd like to get a better ...
3 years, 9 months ago (2017-03-16 22:25:15 UTC) #43
servolk
On 2017/03/16 22:25:15, DaleCurtis wrote: > Do you have a demo page for this functionality? ...
3 years, 9 months ago (2017-03-16 22:35:57 UTC) #44
servolk
On 2017/03/16 22:35:57, servolk wrote: > On 2017/03/16 22:25:15, DaleCurtis wrote: > > Do you ...
3 years, 9 months ago (2017-03-16 22:44:58 UTC) #45
servolk
On 2017/03/16 22:44:58, servolk wrote: > On 2017/03/16 22:35:57, servolk wrote: > > On 2017/03/16 ...
3 years, 9 months ago (2017-03-16 23:29:20 UTC) #46
servolk
On 2017/03/16 23:29:20, servolk wrote: > On 2017/03/16 22:44:58, servolk wrote: > > On 2017/03/16 ...
3 years, 9 months ago (2017-03-17 22:32:14 UTC) #47
DaleCurtis
Sorry don't have time to look at this until next week.
3 years, 9 months ago (2017-03-17 22:43:24 UTC) #50
xhwang
On 2017/03/17 22:43:24, DaleCurtis wrote: > Sorry don't have time to look at this until ...
3 years, 9 months ago (2017-03-17 23:42:36 UTC) #51
servolk
On 2017/03/17 23:42:36, xhwang_slow wrote: > On 2017/03/17 22:43:24, DaleCurtis wrote: > > Sorry don't ...
3 years, 9 months ago (2017-03-18 00:00:21 UTC) #54
xhwang
On 2017/03/18 00:00:21, servolk wrote: > On 2017/03/17 23:42:36, xhwang_slow wrote: > > On 2017/03/17 ...
3 years, 9 months ago (2017-03-18 00:05:39 UTC) #55
servolk
On 2017/03/18 00:05:39, xhwang_slow wrote: > On 2017/03/18 00:00:21, servolk wrote: > > On 2017/03/17 ...
3 years, 9 months ago (2017-03-22 21:48:09 UTC) #64
whywhat
Note there's a pattern of overriding the default renderer factory for other reasons: - on ...
3 years, 9 months ago (2017-03-22 21:53:21 UTC) #66
xhwang
(sorry to reply this message I have to publish some comments I already have on ...
3 years, 9 months ago (2017-03-22 22:31:13 UTC) #67
xhwang
Meanwhile, please help check other decoder creation and make sure they are okay to be ...
3 years, 9 months ago (2017-03-22 22:33:59 UTC) #68
servolk
On 2017/03/22 21:53:21, whywhat wrote: > Note there's a pattern of overriding the default renderer ...
3 years, 9 months ago (2017-03-22 23:31:23 UTC) #69
servolk
On 2017/03/22 22:31:13, xhwang_slow wrote: > (sorry to reply this message I have to publish ...
3 years, 9 months ago (2017-03-22 23:32:51 UTC) #70
xhwang
On 2017/03/22 23:32:51, servolk wrote: > On 2017/03/22 22:31:13, xhwang_slow wrote: > > (sorry to ...
3 years, 9 months ago (2017-03-22 23:38:01 UTC) #71
servolk
https://codereview.chromium.org/2684103005/diff/160001/media/renderers/audio_renderer_impl.h File media/renderers/audio_renderer_impl.h (right): https://codereview.chromium.org/2684103005/diff/160001/media/renderers/audio_renderer_impl.h#newcode101 media/renderers/audio_renderer_impl.h:101: // when it is in a kFlushed and stopped ...
3 years, 9 months ago (2017-03-23 17:08:10 UTC) #78
servolk
On 2017/03/23 17:08:10, servolk wrote: > https://codereview.chromium.org/2684103005/diff/160001/media/renderers/audio_renderer_impl.h > File media/renderers/audio_renderer_impl.h (right): > > https://codereview.chromium.org/2684103005/diff/160001/media/renderers/audio_renderer_impl.h#newcode101 > ...
3 years, 9 months ago (2017-03-24 02:13:08 UTC) #85
DaleCurtis
https://codereview.chromium.org/2684103005/diff/200001/content/renderer/media/media_interface_provider.cc File content/renderer/media/media_interface_provider.cc (right): https://codereview.chromium.org/2684103005/diff/200001/content/renderer/media/media_interface_provider.cc#newcode33 content/renderer/media/media_interface_provider.cc:33: weak_factory_.GetWeakPtr(), interface_name, Can't vend WeakPtrs from a different thread ...
3 years, 9 months ago (2017-03-24 19:35:22 UTC) #86
DaleCurtis
This will need layout tests or browser tests for end to end integration testing.
3 years, 9 months ago (2017-03-24 19:35:48 UTC) #87
servolk
https://codereview.chromium.org/2684103005/diff/200001/content/renderer/media/media_interface_provider.cc File content/renderer/media/media_interface_provider.cc (right): https://codereview.chromium.org/2684103005/diff/200001/content/renderer/media/media_interface_provider.cc#newcode33 content/renderer/media/media_interface_provider.cc:33: weak_factory_.GetWeakPtr(), interface_name, On 2017/03/24 19:35:22, DaleCurtis wrote: > Can't ...
3 years, 9 months ago (2017-03-24 21:15:32 UTC) #90
xhwang
servolk: Sorry I have an important CL to finish today. I'll take a look at ...
3 years, 9 months ago (2017-03-24 21:17:34 UTC) #91
servolk
On 2017/03/24 19:35:48, DaleCurtis wrote: > This will need layout tests or browser tests for ...
3 years, 9 months ago (2017-03-24 21:18:05 UTC) #92
DaleCurtis
https://codereview.chromium.org/2684103005/diff/200001/content/renderer/media/media_interface_provider.cc File content/renderer/media/media_interface_provider.cc (right): https://codereview.chromium.org/2684103005/diff/200001/content/renderer/media/media_interface_provider.cc#newcode33 content/renderer/media/media_interface_provider.cc:33: weak_factory_.GetWeakPtr(), interface_name, On 2017/03/24 at 21:15:32, servolk wrote: > ...
3 years, 9 months ago (2017-03-24 21:30:38 UTC) #93
servolk
https://codereview.chromium.org/2684103005/diff/200001/media/renderers/audio_renderer_impl.cc File media/renderers/audio_renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/200001/media/renderers/audio_renderer_impl.cc#newcode339 media/renderers/audio_renderer_impl.cc:339: if (state_ == kFlushed) On 2017/03/24 21:30:38, DaleCurtis wrote: ...
3 years, 9 months ago (2017-03-24 22:18:13 UTC) #94
DaleCurtis
https://codereview.chromium.org/2684103005/diff/200001/media/renderers/audio_renderer_impl.cc File media/renderers/audio_renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/200001/media/renderers/audio_renderer_impl.cc#newcode339 media/renderers/audio_renderer_impl.cc:339: if (state_ == kFlushed) On 2017/03/24 at 22:18:13, servolk ...
3 years, 9 months ago (2017-03-24 22:20:02 UTC) #95
servolk
On 2017/03/24 21:18:05, servolk wrote: > On 2017/03/24 19:35:48, DaleCurtis wrote: > > This will ...
3 years, 9 months ago (2017-03-25 01:35:16 UTC) #98
xhwang
I haven't looked at the tests yet. But the implementation makes sense to me! I ...
3 years, 9 months ago (2017-03-27 19:13:54 UTC) #101
DaleCurtis
Overall lg, but can you clarify the expectations of what is allowed to happen between ...
3 years, 9 months ago (2017-03-27 21:01:27 UTC) #102
servolk
https://codereview.chromium.org/2684103005/diff/260001/content/renderer/media/media_interface_provider.cc File content/renderer/media/media_interface_provider.cc (right): https://codereview.chromium.org/2684103005/diff/260001/content/renderer/media/media_interface_provider.cc#newcode36 content/renderer/media/media_interface_provider.cc:36: } On 2017/03/27 19:13:53, xhwang_slow wrote: > nit: empty ...
3 years, 9 months ago (2017-03-27 22:34:13 UTC) #104
xhwang
+dcastagna: see my question below Here's my last round of comments. I think Dale made ...
3 years, 8 months ago (2017-03-29 00:16:48 UTC) #109
servolk
https://codereview.chromium.org/2684103005/diff/260001/media/blink/webmediaplayer_impl.cc File media/blink/webmediaplayer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/260001/media/blink/webmediaplayer_impl.cc#newcode1051 media/blink/webmediaplayer_impl.cc:1051: /*enabled*/ first_audio_track); On 2017/03/29 00:16:47, xhwang_slow wrote: > On ...
3 years, 8 months ago (2017-03-29 01:49:34 UTC) #111
servolk
On 2017/03/27 21:01:27, DaleCurtis wrote: > Overall lg, but can you clarify the expectations of ...
3 years, 8 months ago (2017-03-29 01:55:37 UTC) #112
Daniele Castagna
On 2017/03/29 at 00:16:48, xhwang wrote: > +dcastagna: see my question below > > Here's ...
3 years, 8 months ago (2017-03-29 01:59:30 UTC) #113
xhwang
On 2017/03/29 01:55:37, servolk wrote: > On 2017/03/27 21:01:27, DaleCurtis wrote: > > Overall lg, ...
3 years, 8 months ago (2017-03-29 05:12:04 UTC) #114
xhwang
On 2017/03/29 01:59:30, Daniele Castagna wrote: > On 2017/03/29 at 00:16:48, xhwang wrote: > > ...
3 years, 8 months ago (2017-03-29 05:15:48 UTC) #115
servolk
On 2017/03/29 05:12:04, xhwang_slow wrote: > On 2017/03/29 01:55:37, servolk wrote: > > On 2017/03/27 ...
3 years, 8 months ago (2017-03-31 00:29:13 UTC) #120
servolk
On 2017/03/31 00:29:13, servolk wrote: > On 2017/03/29 05:12:04, xhwang_slow wrote: > > On 2017/03/29 ...
3 years, 8 months ago (2017-03-31 00:29:54 UTC) #121
Daniele Castagna
https://codereview.chromium.org/2684103005/diff/360001/media/video/gpu_memory_buffer_video_frame_pool.h File media/video/gpu_memory_buffer_video_frame_pool.h (right): https://codereview.chromium.org/2684103005/diff/360001/media/video/gpu_memory_buffer_video_frame_pool.h#newcode28 media/video/gpu_memory_buffer_video_frame_pool.h:28: // frames. GPU memory buffers are ref-counted and will ...
3 years, 8 months ago (2017-03-31 00:58:13 UTC) #126
servolk
https://codereview.chromium.org/2684103005/diff/360001/media/video/gpu_memory_buffer_video_frame_pool.h File media/video/gpu_memory_buffer_video_frame_pool.h (right): https://codereview.chromium.org/2684103005/diff/360001/media/video/gpu_memory_buffer_video_frame_pool.h#newcode28 media/video/gpu_memory_buffer_video_frame_pool.h:28: // frames. GPU memory buffers are ref-counted and will ...
3 years, 8 months ago (2017-03-31 01:04:19 UTC) #127
Daniele Castagna
https://codereview.chromium.org/2684103005/diff/360001/media/video/gpu_memory_buffer_video_frame_pool.h File media/video/gpu_memory_buffer_video_frame_pool.h (right): https://codereview.chromium.org/2684103005/diff/360001/media/video/gpu_memory_buffer_video_frame_pool.h#newcode28 media/video/gpu_memory_buffer_video_frame_pool.h:28: // frames. GPU memory buffers are ref-counted and will ...
3 years, 8 months ago (2017-03-31 01:20:54 UTC) #130
servolk
https://codereview.chromium.org/2684103005/diff/360001/media/video/gpu_memory_buffer_video_frame_pool.h File media/video/gpu_memory_buffer_video_frame_pool.h (right): https://codereview.chromium.org/2684103005/diff/360001/media/video/gpu_memory_buffer_video_frame_pool.h#newcode28 media/video/gpu_memory_buffer_video_frame_pool.h:28: // frames. GPU memory buffers are ref-counted and will ...
3 years, 8 months ago (2017-03-31 01:23:21 UTC) #131
servolk
On 2017/03/31 01:23:21, servolk wrote: > https://codereview.chromium.org/2684103005/diff/360001/media/video/gpu_memory_buffer_video_frame_pool.h > File media/video/gpu_memory_buffer_video_frame_pool.h (right): > > https://codereview.chromium.org/2684103005/diff/360001/media/video/gpu_memory_buffer_video_frame_pool.h#newcode28 > ...
3 years, 8 months ago (2017-03-31 20:20:33 UTC) #136
DaleCurtis
Did you ever find anything more about seeking and track changes? The last message says ...
3 years, 8 months ago (2017-03-31 21:22:08 UTC) #137
xhwang
https://codereview.chromium.org/2684103005/diff/400001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/400001/media/renderers/renderer_impl.cc#newcode229 media/renderers/renderer_impl.cc:229: void RendererImpl::OnStreamStatusChanged(DemuxerStream* stream, nit: method definition order should match ...
3 years, 8 months ago (2017-03-31 23:38:12 UTC) #140
servolk
https://codereview.chromium.org/2684103005/diff/400001/content/renderer/media/media_interface_provider.cc File content/renderer/media/media_interface_provider.cc (right): https://codereview.chromium.org/2684103005/diff/400001/content/renderer/media/media_interface_provider.cc#newcode20 content/renderer/media/media_interface_provider.cc:20: task_runner_ = base::ThreadTaskRunnerHandle::Get(); On 2017/03/31 21:22:08, DaleCurtis wrote: > ...
3 years, 8 months ago (2017-03-31 23:53:55 UTC) #141
DaleCurtis
Thanks for the tests, just one last question. https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc#newcode210 media/renderers/renderer_impl.cc:210: if ...
3 years, 8 months ago (2017-04-03 19:17:59 UTC) #142
servolk
https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc#newcode210 media/renderers/renderer_impl.cc:210: if (pending_flush_cb_) { On 2017/04/03 19:17:59, DaleCurtis wrote: > ...
3 years, 8 months ago (2017-04-03 20:27:46 UTC) #143
servolk
https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl_unittest.cc File media/renderers/renderer_impl_unittest.cc (right): https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl_unittest.cc#newcode1072 media/renderers/renderer_impl_unittest.cc:1072: } // namespace medi On 2017/04/03 19:17:59, DaleCurtis wrote: ...
3 years, 8 months ago (2017-04-03 20:31:12 UTC) #144
servolk
https://codereview.chromium.org/2684103005/diff/400001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/400001/media/renderers/renderer_impl.cc#newcode229 media/renderers/renderer_impl.cc:229: void RendererImpl::OnStreamStatusChanged(DemuxerStream* stream, On 2017/03/31 23:53:55, servolk wrote: > ...
3 years, 8 months ago (2017-04-03 21:32:33 UTC) #147
DaleCurtis
lgtm, please wait for xhwang@'s approval too though. https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc#newcode210 media/renderers/renderer_impl.cc:210: if ...
3 years, 8 months ago (2017-04-03 21:32:41 UTC) #148
servolk
https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc#newcode210 media/renderers/renderer_impl.cc:210: if (pending_flush_cb_) { On 2017/04/03 21:32:41, DaleCurtis wrote: > ...
3 years, 8 months ago (2017-04-03 22:38:33 UTC) #149
DaleCurtis
https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc#newcode210 media/renderers/renderer_impl.cc:210: if (pending_flush_cb_) { On 2017/04/03 at 22:38:33, servolk wrote: ...
3 years, 8 months ago (2017-04-03 22:50:35 UTC) #150
servolk
https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/440001/media/renderers/renderer_impl.cc#newcode210 media/renderers/renderer_impl.cc:210: if (pending_flush_cb_) { On 2017/04/03 22:50:35, DaleCurtis wrote: > ...
3 years, 8 months ago (2017-04-04 00:04:13 UTC) #153
xhwang
I chat with Sergey offline. The current CL is mostly working but it's getting kinda ...
3 years, 8 months ago (2017-04-04 00:10:15 UTC) #154
xhwang
On 2017/04/04 00:10:15, xhwang_slow wrote: > I chat with Sergey offline. The current CL is ...
3 years, 8 months ago (2017-04-05 06:29:47 UTC) #155
servolk
On 2017/04/05 06:29:47, xhwang_slow wrote: > On 2017/04/04 00:10:15, xhwang_slow wrote: > > I chat ...
3 years, 8 months ago (2017-04-05 16:58:39 UTC) #156
servolk
On 2017/04/05 16:58:39, servolk wrote: > On 2017/04/05 06:29:47, xhwang_slow wrote: > > On 2017/04/04 ...
3 years, 8 months ago (2017-04-07 16:31:59 UTC) #163
xhwang
looking good. just two questions! https://codereview.chromium.org/2684103005/diff/520001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/520001/media/renderers/renderer_impl.cc#newcode211 media/renderers/renderer_impl.cc:211: base::Bind(&RendererImpl::Flush, weak_this_, pending_flush_cb_)); Can ...
3 years, 8 months ago (2017-04-10 18:57:30 UTC) #170
servolk
https://codereview.chromium.org/2684103005/diff/520001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/520001/media/renderers/renderer_impl.cc#newcode211 media/renderers/renderer_impl.cc:211: base::Bind(&RendererImpl::Flush, weak_this_, pending_flush_cb_)); On 2017/04/10 18:57:30, xhwang_slow wrote: > ...
3 years, 8 months ago (2017-04-10 20:21:23 UTC) #171
servolk
https://codereview.chromium.org/2684103005/diff/520001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/520001/media/renderers/renderer_impl.cc#newcode211 media/renderers/renderer_impl.cc:211: base::Bind(&RendererImpl::Flush, weak_this_, pending_flush_cb_)); On 2017/04/10 20:21:22, servolk wrote: > ...
3 years, 8 months ago (2017-04-10 20:29:54 UTC) #174
xhwang
https://codereview.chromium.org/2684103005/diff/520001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/520001/media/renderers/renderer_impl.cc#newcode211 media/renderers/renderer_impl.cc:211: base::Bind(&RendererImpl::Flush, weak_this_, pending_flush_cb_)); On 2017/04/10 20:29:53, servolk wrote: > ...
3 years, 8 months ago (2017-04-11 00:29:41 UTC) #177
servolk
https://codereview.chromium.org/2684103005/diff/520001/media/renderers/renderer_impl.cc File media/renderers/renderer_impl.cc (right): https://codereview.chromium.org/2684103005/diff/520001/media/renderers/renderer_impl.cc#newcode211 media/renderers/renderer_impl.cc:211: base::Bind(&RendererImpl::Flush, weak_this_, pending_flush_cb_)); On 2017/04/11 00:29:41, xhwang_slow wrote: > ...
3 years, 8 months ago (2017-04-11 01:14:05 UTC) #178
xhwang
LGTM, thank you for the patience! :)
3 years, 8 months ago (2017-04-11 16:47:06 UTC) #185
servolk
On 2017/04/11 16:47:06, xhwang_slow wrote: > LGTM, thank you for the patience! :) Thank you ...
3 years, 8 months ago (2017-04-11 16:53:24 UTC) #186
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684103005/590001
3 years, 8 months ago (2017-04-11 16:54:07 UTC) #189
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 17:01:56 UTC) #192
Message was sent while issue was closed.
Committed patchset #31 (id:590001) as
https://chromium.googlesource.com/chromium/src/+/16e8bdf82977fa97342632486665...

Powered by Google App Engine
This is Rietveld 408576698