Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2681733006: Rename gfx::OZONE_NATIVE_PIXMAP to gfx::NATIVE_PIXMAP (Closed)

Created:
3 years, 10 months ago by Julien Isorce
Modified:
3 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::OZONE_NATIVE_PIXMAP to gfx::NATIVE_PIXMAP While it is currently only used on ozone platforms, this type is not specific to ozone. In followup CLs this GpuMemoryBufferType will be use on linux platform. Indeed this CL is a pre-step to enable glCreateImageCHROMIUM with linux dma buf on OS_LINUX. BUG=584248 R=reveman@chromium.org, sadrul@chromium.org, tsepez@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2681733006 Cr-Commit-Position: refs/heads/master@{#455831} Committed: https://chromium.googlesource.com/chromium/src/+/6117f22be46bb2a998e8e27095a46c1a5914e171

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -22 lines) Patch
M components/exo/display.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/ipc/common/gpu_memory_buffer_support.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/host/gpu_memory_buffer_support.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M gpu/ipc/service/gpu_memory_buffer_factory_ozone_native_pixmap.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gpu_memory_buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/gpu_memory_buffer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/mojo/buffer_types.mojom View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/mojo/buffer_types_struct_traits.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M ui/gfx/mojo/buffer_types_struct_traits.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/mojo/struct_traits_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 35 (25 generated)
Julien Isorce
Hi David, please take a look. Thx.
3 years, 10 months ago (2017-02-23 14:08:20 UTC) #2
reveman
lgtm are the GpuMemoryBuffer*OzoneNativePixmap classes and the files being renamed too? Separate CL?
3 years, 10 months ago (2017-02-23 17:33:23 UTC) #7
Julien Isorce
On 2017/02/23 17:33:23, reveman wrote: > lgtm > > are the GpuMemoryBuffer*OzoneNativePixmap classes and the ...
3 years, 10 months ago (2017-02-24 11:19:09 UTC) #10
Julien Isorce
Hi sadrul@, please take a look. Thx!
3 years, 9 months ago (2017-03-07 17:04:14 UTC) #13
sadrul
lgtm. But you need security review. +tsepez@
3 years, 9 months ago (2017-03-08 02:06:12 UTC) #20
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-08 17:10:22 UTC) #21
Julien Isorce
** Presubmit Messages ** Missing OWNER reviewers for these files: media/gpu/video_decode_accelerator_unittest.cc Hi Dale, please take ...
3 years, 9 months ago (2017-03-09 13:07:17 UTC) #28
DaleCurtis
lgtm
3 years, 9 months ago (2017-03-09 18:42:45 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2681733006/80001
3 years, 9 months ago (2017-03-09 19:33:06 UTC) #32
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 19:40:05 UTC) #35
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/6117f22be46bb2a998e8e27095a4...

Powered by Google App Engine
This is Rietveld 408576698