Source/bindings/dart/custom/DartHTMLOptionsCollectionCustom.cpp - Issue 26789007: Add a native subtype of function that uses the native C++ class hierarchy to check if an element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/dart/custom/DartHTMLOptionsCollectionCustom.cpp

Issue 26789007: Add a native subtype of function that uses the native C++ class hierarchy to check if an element (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit/

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/dart/custom/DartDOMStringListCustom.cpp ('k') | Source/bindings/dart/custom/DartWebSocketCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/dart/custom/DartHTMLOptionsCollectionCustom.cpp

===================================================================

--- Source/bindings/dart/custom/DartHTMLOptionsCollectionCustom.cpp (revision 1437)

+++ Source/bindings/dart/custom/DartHTMLOptionsCollectionCustom.cpp (working copy)

@@ -57,8 +57,7 @@

goto fail;

Dart_Handle elementArgument = Dart_GetNativeArgument(args, 2);

- DartDOMData* domData = static_cast<DartDOMData*>(Dart_GetNativeIsolateData(args));

- if (!DartDOMWrapper::instanceOf<DartHTMLOptionElement>(domData, elementArgument)) {

+ if (!DartDOMWrapper::subtypeOf(elementArgument, DartHTMLOptionElement::dartClassId)) {

exception = DartDOMWrapper::exceptionCodeToDartException(TypeMismatchError);

goto fail;

}

« no previous file with comments | « Source/bindings/dart/custom/DartDOMStringListCustom.cpp ('k') | Source/bindings/dart/custom/DartWebSocketCustom.cpp » ('j') | no next file with comments »