Issue 26789007: Add a native subtype of function that uses the native C++ class hierarchy to check if an element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26789007: Add a native subtype of function that uses the native C++ class hierarchy to check if an element (Closed)

Created:
7 years, 2 months ago by siva

Modified:
7 years, 2 months ago

Reviewers:

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit/

Visibility:
Public.

More Reviews

Description

Add a native subtype of function that uses the native C++ class hierarchy to check if an element is a subtype of the intended type. This ensures that it is not possible to pass in a wrapper that claims to implement an interface and accesses the native pointer incorrectly.

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -57 lines)			Patch
M	Source/bindings/dart/DartCustomElementWrapper.cpp	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	Source/bindings/dart/DartDOMData.h	View	2 chunks	+2 lines, -13 lines	0 comments	Download
M	Source/bindings/dart/DartDOMWrapper.h	View	6 chunks	+28 lines, -10 lines	0 comments	Download
A	Source/bindings/dart/DartLibraryIds.h	View	1 chunk	+51 lines, -0 lines	0 comments	Download
M	Source/bindings/dart/DartNativeUtilities.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/bindings/dart/DartUtilities.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/bindings/dart/DartUtilities.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/bindings/dart/custom/DartBlobCustom.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/bindings/dart/custom/DartDOMStringListCustom.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	Source/bindings/dart/custom/DartHTMLOptionsCollectionCustom.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/bindings/dart/custom/DartWebSocketCustom.cpp	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/bindings/dart/custom/DartXMLHttpRequestCustom.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/dart/gyp/dartium.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/dart/gyp/overrides.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download