Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 26764004: Invoke generated lexer along with baseline lexer to compare results. (Closed)

Created:
7 years, 2 months ago by ulan
Modified:
7 years, 2 months ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

Invoke generated lexer along with baseline lexer to compare results. BUG= R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17200

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -305 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
A + src/lexer/lexer.h View 1 chunk +20 lines, -21 lines 0 comments Download
M src/lexer/lexer.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M src/lexer/lexer.re View 14 chunks +168 lines, -262 lines 1 comment Download
M src/lexer/lexer-shell.cc View 4 chunks +28 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL https://chromiumcodereview.appspot.com/26764004/diff/1/src/lexer/lexer.re File src/lexer/lexer.re (right): https://chromiumcodereview.appspot.com/26764004/diff/1/src/lexer/lexer.re#newcode23 src/lexer/lexer.re:23: EConditionHtmlComment Had to move it here from the ...
7 years, 2 months ago (2013-10-14 14:28:52 UTC) #1
marja
lgtm
7 years, 2 months ago (2013-10-14 14:33:24 UTC) #2
ulan
7 years, 2 months ago (2013-10-14 14:35:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17200 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698