Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 26753005: Adding compositor callbacks to RenderWidgetHostViewAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Separate Compositor plumbing from SetContentView Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index 5429e4a219ecc517fae2893f041c1f2dc4494fd8..3cf0690bb3ab38dfb9665db809e491514f873f1e 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -19,6 +19,7 @@
#include "cc/layers/texture_layer_client.h"
#include "cc/output/begin_frame_args.h"
#include "content/browser/accessibility/browser_accessibility_manager.h"
+#include "content/browser/renderer_host/compositor_observer.h"
#include "content/browser/renderer_host/image_transport_factory_android.h"
#include "content/browser/renderer_host/ime_adapter_android.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
@@ -49,6 +50,7 @@ class WebMouseEvent;
}
namespace content {
+class Compositor;
class ContentViewCoreImpl;
class OverscrollGlow;
class RenderWidgetHost;
@@ -61,9 +63,8 @@ struct NativeWebKeyboardEvent;
class RenderWidgetHostViewAndroid
: public RenderWidgetHostViewBase,
public BrowserAccessibilityDelegate,
- public cc::TextureLayerClient,
- public cc::DelegatedRendererLayerClient,
public cc::DelegatedFrameResourceCollectionClient,
+ public CompositorObserver,
public ImageTransportFactoryAndroidObserver {
public:
RenderWidgetHostViewAndroid(RenderWidgetHostImpl* widget,
@@ -188,25 +189,18 @@ class RenderWidgetHostViewAndroid
virtual gfx::Point GetLastTouchEventLocation() const OVERRIDE;
virtual void FatalAccessibilityTreeError() OVERRIDE;
- // cc::TextureLayerClient implementation.
- virtual unsigned PrepareTexture() OVERRIDE;
- virtual WebKit::WebGraphicsContext3D* Context3d() OVERRIDE;
- virtual bool PrepareTextureMailbox(
- cc::TextureMailbox* mailbox,
- scoped_ptr<cc::SingleReleaseCallback>* release_callback,
- bool use_shared_memory) OVERRIDE;
-
- // cc::DelegatedRendererLayerClient implementation.
- virtual void DidCommitFrameData() OVERRIDE;
-
// cc::DelegatedFrameResourceCollectionClient implementation.
virtual void UnusedResourcesAreAvailable() OVERRIDE;
+ // content::CompositorObserver implementation.
+ virtual void OnCompositingDidCommit(Compositor* compositor) OVERRIDE;
+
// ImageTransportFactoryAndroidObserver implementation.
virtual void OnLostResources() OVERRIDE;
// Non-virtual methods
void SetContentViewCore(ContentViewCoreImpl* content_view_core);
+ void SetCompositor(Compositor* compositor);
SkColor GetCachedBackgroundColor() const;
void SendKeyEvent(const NativeWebKeyboardEvent& event);
void SendTouchEvent(const WebKit::WebTouchEvent& event);
@@ -335,6 +329,8 @@ class RenderWidgetHostViewAndroid
bool flush_input_requested_;
+ Compositor* compositor_;
+
DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAndroid);
};

Powered by Google App Engine
This is Rietveld 408576698