content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java - Issue 26753005: Adding compositor callbacks to RenderWidgetHostViewAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

Issue 26753005: Adding compositor callbacks to RenderWidgetHostViewAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments and rebased Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_widget_host_view_android.cc ('K') | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/public/browser/android/compositor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

index 3c7f70bbfed632537eb6bbe7851df3f8718ac582..5a5232ea048915374b0f1540b0b1a9479980e0ce 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

@@ -18,6 +18,7 @@ import android.widget.FrameLayout;

import org.chromium.base.CalledByNative;

import org.chromium.base.JNINamespace;

import org.chromium.content.common.TraceEvent;

+import org.chromium.ui.base.WindowAndroid;

/***

* This view is used by a ContentView to render its content.

@@ -53,10 +54,10 @@ public class ContentViewRenderView extends FrameLayout {

* Native code should add/remove the layers to be rendered through the ContentViewLayerRenderer.

* @param context The context used to create this.

- public ContentViewRenderView(Context context) {

+ public ContentViewRenderView(Context context, WindowAndroid rootWindow) {

super(context);

- mNativeContentViewRenderView = nativeInit();

+ assert rootWindow != null;

+ mNativeContentViewRenderView = nativeInit(rootWindow.getNativePointer());

assert mNativeContentViewRenderView != 0;

setBackgroundColor(Color.WHITE);

@@ -290,7 +291,7 @@ public class ContentViewRenderView extends FrameLayout {

}

- private native int nativeInit();

+ private native int nativeInit(long nativeRootWindow);

private native void nativeDestroy(int nativeContentViewRenderView);

private native void nativeSetCurrentContentView(int nativeContentViewRenderView,

int nativeContentView);