android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java - Issue 267253007: Use LoadURLWithParams in ChromeWebContentsDelegateAndroid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

Issue 267253007: Use LoadURLWithParams in ChromeWebContentsDelegateAndroid (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed other NavigationController call sites for Android Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

index 014415f5ef0957ac50e89ae0946e564d15aec244..7e0856624dfa4c9254c40f9be7e33ceef7e7ce8d 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java

@@ -110,7 +110,8 @@ class AwWebContentsDelegateAdapter extends AwWebContentsDelegate {

}

@Override

- public void openNewTab(String url, String extraHeaders, byte[] postData, int disposition) {

+ public void openNewTab(String url, String extraHeaders, byte[] postData, int disposition,

+ boolean isRendererInitiated) {

// This is only called in chrome layers.

assert false;

}