Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2672193003: media: Add "Hide players" button in about://media-internals (Closed)

Created:
3 years, 10 months ago by xhwang
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org, wolenetz, watk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Add "Hide players" button in about://media-internals What this does is: - Adds a button to hide all current players on the page, but doesn't touch the C++ side to actually delete those players. - After a player is hidden, new logs for that player will be dropped and will not resurrect any hidden players. - If a user refreshes the media-internals page, or open a new one, we'll get all players back. BUG=688607 Review-Url: https://codereview.chromium.org/2672193003 Cr-Commit-Position: refs/heads/master@{#448764} Committed: https://chromium.googlesource.com/chromium/src/+/4ee2eeb27fb5cb49b1d5fa470528c16738d0274d

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M content/browser/resources/media/manager.js View 1 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/resources/media/media_internals.html View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
xhwang
As discussed offline with sandersd. Maybe we can land this first, then sandersd@ will add ...
3 years, 10 months ago (2017-02-07 20:43:22 UTC) #11
sandersd (OOO until July 31)
lgtm
3 years, 10 months ago (2017-02-07 20:45:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672193003/20001
3 years, 10 months ago (2017-02-07 20:49:49 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4ee2eeb27fb5cb49b1d5fa470528c16738d0274d
3 years, 10 months ago (2017-02-07 22:57:56 UTC) #18
shimazu
3 years, 10 months ago (2017-02-08 01:31:08 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2682013002/ by shimazu@chromium.org.

The reason for reverting is: Two following tests fail:
-
 WebUIResourceBrowserTest.MediaInternals_Integration
- WebUIResourceBrowserTest.MediaInternals_Manager.

Powered by Google App Engine
This is Rietveld 408576698