ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm - Issue 2671743002: Separate state of basic and advanced tab in CBD dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm

Issue 2671743002: Separate state of basic and advanced tab in CBD dialog (Closed)

Patch Set: rebase and fix compilation Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/browsing_data/browsing_data_counter_wrapper.cc ('k') | ios/chrome/browser/browsing_data/cache_counter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm

diff --git a/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm b/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm

index a04ec4d416cd2c844f42be162f75d7b378474a7b..50ce1585cb24af2b7d7a955dccce50987bd0f740 100644

--- a/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm

+++ b/ios/chrome/browser/browsing_data/browsing_data_removal_controller.mm

@@ -173,7 +173,7 @@ void DoNothing(int n) {}

decrementCallbackCounterCount];

if (mask & IOSChromeBrowsingDataRemover::REMOVE_DOWNLOADS) {

- DCHECK_EQ(browsing_data::ALL_TIME, timePeriod)

+ DCHECK_EQ(browsing_data::TimePeriod::ALL_TIME, timePeriod)

<< "Partial clearing not supported";

callbackCounter->IncrementCount();

[_delegate