chrome/browser/extensions/api/browsing_data/browsing_data_api.cc - Issue 2671743002: Separate state of basic and advanced tab in CBD dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

Issue 2671743002: Separate state of basic and advanced tab in CBD dialog (Closed)

Patch Set: rebase and fix compilation Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

index e8474db05fcc253855bbe04c2b52b9c134769905..36610d55c902dac485a94408872904229def0f15 100644

--- a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

+++ b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

@@ -145,7 +145,7 @@ ExtensionFunction::ResponseAction BrowsingDataSettingsFunction::Run() {

browsing_data::TimePeriod period =

static_cast<browsing_data::TimePeriod>(period_pref);

double since = 0;

- if (period != browsing_data::ALL_TIME) {

+ if (period != browsing_data::TimePeriod::ALL_TIME) {

base::Time time = browsing_data::CalculateBeginDeleteTime(period);

since = time.ToJsTime();

}