Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3478)

Unified Diff: chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc

Issue 2671743002: Separate state of basic and advanced tab in CBD dialog (Closed)
Patch Set: rebase and fix compilation Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc
diff --git a/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc b/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc
index ffd8e913d38dd52813c971b167f6b738f5503ef1..634d1720e1876606f52d42f7b559bbf3908b0409 100644
--- a/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc
+++ b/chrome/browser/android/browsing_data/browsing_data_counter_bridge.cc
@@ -10,21 +10,31 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/common/pref_names.h"
-#include "components/browsing_data/core/browsing_data_utils.h"
#include "jni/BrowsingDataCounterBridge_jni.h"
using base::android::JavaParamRef;
using base::android::ScopedJavaLocalRef;
BrowsingDataCounterBridge::BrowsingDataCounterBridge(
- JNIEnv* env, const JavaParamRef<jobject>& obj, jint data_type)
+ JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jint data_type,
+ jint clear_browsing_data_tab)
: jobject_(obj) {
DCHECK_GE(data_type, 0);
- DCHECK_LT(data_type, browsing_data::NUM_TYPES);
+ DCHECK_LT(data_type,
+ static_cast<int>(browsing_data::BrowsingDataType::NUM_TYPES));
+ DCHECK_GE(clear_browsing_data_tab, 0);
+ DCHECK_LT(clear_browsing_data_tab,
+ static_cast<int>(browsing_data::ClearBrowsingDataTab::NUM_TYPES));
+
+ clear_browsing_data_tab_ =
+ static_cast<browsing_data::ClearBrowsingDataTab>(clear_browsing_data_tab);
std::string pref;
if (!browsing_data::GetDeletionPreferenceFromDataType(
- static_cast<browsing_data::BrowsingDataType>(data_type), &pref)) {
+ static_cast<browsing_data::BrowsingDataType>(data_type),
+ clear_browsing_data_tab_, &pref)) {
return;
}
@@ -35,7 +45,7 @@ BrowsingDataCounterBridge::BrowsingDataCounterBridge(
if (!counter_)
return;
- counter_->Init(profile->GetPrefs(),
+ counter_->Init(profile->GetPrefs(), clear_browsing_data_tab_,
base::Bind(&BrowsingDataCounterBridge::onCounterFinished,
base::Unretained(this)));
counter_->Restart();
@@ -64,8 +74,10 @@ void BrowsingDataCounterBridge::onCounterFinished(
result_string);
}
-static jlong Init(
- JNIEnv* env, const JavaParamRef<jobject>& obj, int data_type) {
- return reinterpret_cast<intptr_t>(
- new BrowsingDataCounterBridge(env, obj, data_type));
+static jlong Init(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jint data_type,
+ jint clear_browsing_data_tab) {
+ return reinterpret_cast<intptr_t>(new BrowsingDataCounterBridge(
+ env, obj, data_type, clear_browsing_data_tab));
}

Powered by Google App Engine
This is Rietveld 408576698