Use C source for openssl RC4 calculation instead of ASM

openssl.gyp

Index: openssl.gyp
diff --git a/openssl.gyp b/openssl.gyp
index 80733269d8bd30fb1aed695efa697d3a9e3aba8d..b599b7628a9857b1c6645d9f265d8eff2d6eb15b 100644
--- a/openssl.gyp
+++ b/openssl.gyp
@@ -65,6 +65,19 @@
         ['target_arch == "x64"', {
           'sources': [ '<@(openssl_x86_64_sources)' ],
           'sources!': [ '<@(openssl_x86_64_source_excludes)' ],

[wtc, 2013/10/15 22:39:15]

Should we change the definitions of openssl_x86_64_sources and
openssl_x86_64_source_excludes instead?

It will require changing openssl/openssl.config and re-running
import_from_android.sh, but it seems like a better way to do this. This assumes
the 'OS != "android"' condition is not necessary.

This may be nontrivial to figure out because we may need to change
openssl/openssl.config with a Chromium-specific patch file. I remember I had a
hard time figuring out how to do this, even though digit documented the
procedure in README.chromium clearly.

[yhirano, 2013/10/17 05:31:42]

I filed a bug https://code.google.com/p/chromium/issues/detail?id=308375

+          'conditions': [
+            ['OS != "android"', {
+              # Due to a goma problem with compiling rc4-x86_64.S,
+              # We use the C rc4 source instead of the ASM source.
+              # This hurts performance, but it's not a problem
+              # because no production code uses openssl on x86-64.
+              'sources/': [
+                ['exclude', 'openssl/crypto/rc4/asm/rc4-x86_64\\.S' ],
+                ['include', 'openssl/crypto/rc4/rc4_enc\\.c' ],
+                ['include', 'openssl/crypto/rc4/rc4_skey\\.c' ],
+              ],
+            }]
+          ],
           'defines': [ '<@(openssl_x86_64_defines)' ],
           'defines!': [ 'OPENSSL_NO_ASM' ],
           'variables': {