tracing/tracing/metrics/v8/gc_metric.html - Issue 2656493002: Register metric Histogram names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/v8/gc_metric.html

Issue 2656493002: Register metric Histogram names. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/metrics/v8/gc_metric.html

diff --git a/tracing/tracing/metrics/v8/gc_metric.html b/tracing/tracing/metrics/v8/gc_metric.html

index b57d94f0f614ec0504ce7c62ac6ec5e628f74ac7..84e7716a0ef5c074442899469c2fe00d70ea7cc3 100644

--- a/tracing/tracing/metrics/v8/gc_metric.html

+++ b/tracing/tracing/metrics/v8/gc_metric.html

@@ -32,7 +32,9 @@ tr.exportTo('tr.metrics.v8', function() {

addV8ExecuteMutatorUtilization(values, model);

}

- tr.metrics.MetricRegistry.register(gcMetric);

+ tr.metrics.MetricRegistry.register(gcMetric, {

+ histogramNames: new Set([]),

+ });

var timeDurationInMs_smallerIsBetter =

tr.b.Unit.byName.timeDurationInMs_smallerIsBetter;