Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: tracing/tracing/metrics/metric_registry_test.html

Issue 2656493002: Register metric Histogram names. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/metrics/metric_registry.html ('k') | tracing/tracing/metrics/sample_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/metrics/metric_registry_test.html
diff --git a/tracing/tracing/metrics/metric_registry_test.html b/tracing/tracing/metrics/metric_registry_test.html
index 135f2518a8b34db1f8a5dd2b1b67d98a9f4ff459..c176f60142af8804952960eb98887e3cc3e9def7 100644
--- a/tracing/tracing/metrics/metric_registry_test.html
+++ b/tracing/tracing/metrics/metric_registry_test.html
@@ -19,7 +19,9 @@ tr.b.unittest.testSuite(function() {
n1.addSample(1);
values.addHistogram(n1);
}
- tr.metrics.MetricRegistry.register(sampleMetricA);
+ tr.metrics.MetricRegistry.register(sampleMetricA, {
+ histogramNames: new Set([]),
+ });
function sampleMetricB(values, model) {
var n1 = new tr.v.Histogram('foo', tr.b.Unit.byName.count);
@@ -29,7 +31,9 @@ tr.b.unittest.testSuite(function() {
values.addHistogram(n1);
values.addHistogram(n2);
}
- tr.metrics.MetricRegistry.register(sampleMetricB);
+ tr.metrics.MetricRegistry.register(sampleMetricB, {
+ histogramNames: new Set([]),
+ });
function sampleMetricC(values, model) {
var n1 = new tr.v.Histogram('foo', tr.b.Unit.byName.count);
@@ -42,7 +46,9 @@ tr.b.unittest.testSuite(function() {
values.addHistogram(n2);
values.addHistogram(n3);
}
- tr.metrics.MetricRegistry.register(sampleMetricC);
+ tr.metrics.MetricRegistry.register(sampleMetricC, {
+ histogramNames: new Set([]),
+ });
var typeInfo = tr.metrics.MetricRegistry.findTypeInfoWithName(
'sampleMetricB');
@@ -61,6 +67,11 @@ tr.b.unittest.testSuite(function() {
assert.throws(function() {
tr.metrics.MetricRegistry.register(function(a) {});
});
+
+ assert.throws(function() {
+ tr.metrics.MetricRegistry.register(function(histograms, model) {
+ });
+ });
});
});
</script>
« no previous file with comments | « tracing/tracing/metrics/metric_registry.html ('k') | tracing/tracing/metrics/sample_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698